Update Kokoro tests for Cloud Run #1629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
lesv
approved these changes
Oct 21, 2019
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| set -eo pipefail |
There was a problem hiding this comment.
I want the script to fail if it doesn't build or deploy the container.
.kokoro/tests/build_cloud_run.sh
Outdated
Comment on lines
26
to
34
| export SAMPLE_VERSION="${KOKORO_GIT_COMMIT:-latest}" | ||
| # Builds not triggered by a PR will fall back to the commit hash then "latest". | ||
| SUFFIX=${KOKORO_GITHUB_PULL_REQUEST_NUMBER:-${SAMPLE_VERSION:0:12}} | ||
| export SERVICE_NAME="${SAMPLE_NAME}-${SUFFIX}" | ||
| export CONTAINER_IMAGE="gcr.io/${GOOGLE_CLOUD_PROJECT}/run-${SAMPLE_NAME}:${SAMPLE_VERSION}" | ||
|
|
||
| # Build the service | ||
| set -x | ||
| gcloud builds submit --tag="${CONTAINER_IMAGE}" |
There was a problem hiding this comment.
Is there some mechanism setup to only keep N versions, or is this just going to grow forever?
There was a problem hiding this comment.
There is a clean up function. I've confirmed it's working. I'm also going to check a few times over the next month to confirm there's nothing broken.
averikitsch
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
averikitsch
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
bradmiro
pushed a commit
that referenced
this pull request
Dec 2, 2019
* Kokoro tests * change for kokoro to run * update bash script * fix clean up and wildcard * sample name fixed * Add todo * test remove pipe to file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.