Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

com.example.vision.DetectIT: testFacesGcs failed #2242

Closed
flaky-bot bot opened this issue Feb 26, 2020 · 5 comments · Fixed by #2254
Closed

com.example.vision.DetectIT: testFacesGcs failed #2242

flaky-bot bot opened this issue Feb 26, 2020 · 5 comments · Fixed by #2254
Assignees
Labels
priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@flaky-bot
Copy link

flaky-bot bot commented Feb 26, 2020

com.example.vision.DetectIT: testFacesGcs failed
buildID: 7faeda4
buildURL: Build Status, Sponge
status: failed

@flaky-bot flaky-bot bot added buildcop: issue priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Feb 26, 2020
@averikitsch averikitsch assigned nnegrey and unassigned averikitsch Feb 26, 2020
@flaky-bot
Copy link
Author

flaky-bot bot commented Feb 27, 2020

buildID: ebffb5a
buildURL: Build Status, Sponge
status: failed

@flaky-bot
Copy link
Author

flaky-bot bot commented Feb 27, 2020

Looks like this issue is flaky. 😟

I'm going to leave this open and stop commenting.

A human should fix and close this.

buildID: 262510e
buildURL: Build Status, Sponge
status: failed

@nnegrey
Copy link
Contributor

nnegrey commented Feb 27, 2020

@tbpg how delayed is the build that build cop builds?

@nnegrey
Copy link
Contributor

nnegrey commented Feb 27, 2020

Like if I close again since the PR with the fix was merged will this come back up today or should I wait till tomorrow?

@tbpg
Copy link

tbpg commented Feb 28, 2020

The Build Cop is based on the nightly/continuous tests. So, it's possible there is a build in progress -> you submit your PR -> the test fails -> this gets reopened, even if your PR did legitimately fix the problem. So, if this should be fixed, I'd mark it as closed. If it fails again, you can check the commit to see if it's before or after your PR.

Hopefully that makes sense. Let me know if there is a way to make this more clear in the docs.

@nnegrey nnegrey closed this as completed Mar 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants