Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create README file for App Engine Java 8 sample #1539

Closed
ludoch opened this issue Aug 7, 2019 · 2 comments
Closed

Create README file for App Engine Java 8 sample #1539

ludoch opened this issue Aug 7, 2019 · 2 comments
Assignees
@averikitsch
Labels
type: cleanup An internal cleanup or hygiene concern.

Comments

@ludoch
Copy link
Contributor

ludoch commented Aug 7, 2019

Nothing under
https://github.com/GoogleCloudPlatform/java-docs-samples/tree/master/appengine-java8/analytics
@kurtisvg kurtisvg self-assigned this Aug 7, 2019
@kurtisvg kurtisvg added the type: cleanup An internal cleanup or hygiene concern. label Aug 12, 2019
@kurtisvg
Copy link
Contributor

@averikitsch - The sample in question looks like it's from 2015 and doesn't have any region tags. Should it have a README, or can it just be removed entirely?

@averikitsch
Copy link
Contributor

averikitsch commented Aug 12, 2019 •
edited
Loading

Based on issue #151, it might be good to keep this sample and add it to the docs. As well as moving the docs reference to java 7 to this sample.

@kurtisvg kurtisvg changed the title Create README file Create README file for App Engine Java 8 sample Oct 21, 2019
@kurtisvg kurtisvg assigned averikitsch and unassigned kurtisvg Oct 21, 2019
@averikitsch averikitsch mentioned this issue Oct 22, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@averikitsch averikitsch

Labels
type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ludoch @averikitsch @kurtisvg