From 4717d6aaa5138d21724c84498305b4f1ab4f36a6 Mon Sep 17 00:00:00 2001 From: Frank Natividad Date: Tue, 7 Feb 2017 16:28:58 -0800 Subject: [PATCH 1/3] Adding temporary fix for devappserver requires version. --- appengine/endpoints-frameworks-v2/discovery/README.md | 8 ++++++++ .../discovery/src/main/webapp/WEB-INF/appengine-web.xml | 4 ++-- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/appengine/endpoints-frameworks-v2/discovery/README.md b/appengine/endpoints-frameworks-v2/discovery/README.md index b14051674e5..deefc8b4ee5 100644 --- a/appengine/endpoints-frameworks-v2/discovery/README.md +++ b/appengine/endpoints-frameworks-v2/discovery/README.md @@ -96,6 +96,13 @@ provided [here][9]. `gradle appengineDeploy` +## Known issues + +There's a [bug][13] where `1` is required in the +[appengine-web.xml](discovery/src/main/webapp/WEB-INF/appengine-web.xml) to run +this sample locally. This will become optional in the near future. + + [1]: https://cloud.google.com/appengine/docs/java/ [2]: http://java.com/en/ [3]: https://cloud.google.com/appengine/docs/java/endpoints/ @@ -108,3 +115,4 @@ provided [here][9]. [10]: https://github.com/GoogleCloudPlatform/endpoints-framework-maven-plugin [11]: https://github.com/GoogleCloudPlatform/endpoints-framework-gradle-plugin [12]: https://cloud.google.com/endpoints/docs/authenticating-users-frameworks +[13]: https://github.com/cloudendpoints/endpoints-java/issues/43 diff --git a/appengine/endpoints-frameworks-v2/discovery/src/main/webapp/WEB-INF/appengine-web.xml b/appengine/endpoints-frameworks-v2/discovery/src/main/webapp/WEB-INF/appengine-web.xml index fa2a39ce840..d0f24ab64f5 100644 --- a/appengine/endpoints-frameworks-v2/discovery/src/main/webapp/WEB-INF/appengine-web.xml +++ b/appengine/endpoints-frameworks-v2/discovery/src/main/webapp/WEB-INF/appengine-web.xml @@ -15,8 +15,8 @@ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. --> - true - + true + 1 From cf7155d33d4cb90cc2bda0e7a3acf1af872874d0 Mon Sep 17 00:00:00 2001 From: Frank Natividad Date: Tue, 7 Feb 2017 16:29:30 -0800 Subject: [PATCH 2/3] Cleaned up build.gradle --- appengine/endpoints-frameworks-v2/discovery/build.gradle | 3 --- 1 file changed, 3 deletions(-) diff --git a/appengine/endpoints-frameworks-v2/discovery/build.gradle b/appengine/endpoints-frameworks-v2/discovery/build.gradle index 74206255983..47af6be51ad 100644 --- a/appengine/endpoints-frameworks-v2/discovery/build.gradle +++ b/appengine/endpoints-frameworks-v2/discovery/build.gradle @@ -24,9 +24,6 @@ buildscript { // Configuration for building } repositories { // repositories for Jar's you access in your code - maven { - url 'https://oss.sonatype.org/content/repositories/snapshots' // SNAPSHOT Repository (if needed) - } mavenCentral() jcenter() } From 95281c34f84accb48f43b10f9bfa84148d5d9890 Mon Sep 17 00:00:00 2001 From: Frank Natividad Date: Tue, 7 Feb 2017 16:32:59 -0800 Subject: [PATCH 3/3] Typo in path to appengine-web.xml --- appengine/endpoints-frameworks-v2/discovery/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/appengine/endpoints-frameworks-v2/discovery/README.md b/appengine/endpoints-frameworks-v2/discovery/README.md index deefc8b4ee5..1f11fbb5c24 100644 --- a/appengine/endpoints-frameworks-v2/discovery/README.md +++ b/appengine/endpoints-frameworks-v2/discovery/README.md @@ -99,7 +99,7 @@ provided [here][9]. ## Known issues There's a [bug][13] where `1` is required in the -[appengine-web.xml](discovery/src/main/webapp/WEB-INF/appengine-web.xml) to run +[appengine-web.xml](src/main/webapp/WEB-INF/appengine-web.xml) to run this sample locally. This will become optional in the near future.