Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update subscriber example in README to current patterns. #6194

Merged
merged 3 commits into from
Oct 12, 2018
Merged

Update subscriber example in README to current patterns. #6194

merged 3 commits into from
Oct 12, 2018

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Oct 11, 2018

Closes #6189.

@tseaver tseaver added documentation api: pubsub Issues related to the Pub/Sub API. labels Oct 11, 2018
@tseaver tseaver requested review from theacodes and crwilcox October 11, 2018 15:38
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 11, 2018
anguillanneuf
anguillanneuf suggested changes Oct 12, 2018
View reviewed changes
Copy link
Contributor

@anguillanneuf anguillanneuf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we also update from google.cloud import pubsub_v1?

It's because everywhere else - in the API Library Doc, such as this page: https://googleapis.github.io/google-cloud-python/latest/pubsub/publisher/api/client.html, as well as in our doc samples - we use pubsub_v1.

Or at lease do from google.cloud import pubsub_v1 as pubsub, so people will expect that they won't run into any issues using v1.

@tseaver
Copy link
Contributor Author

tseaver commented Oct 12, 2018

@anguillanneuf

Could we also update from google.cloud import pubsub_v1?

See aae840a .

anguillanneuf
anguillanneuf suggested changes Oct 12, 2018
View reviewed changes
Copy link
Contributor

@anguillanneuf anguillanneuf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make the same import statement update for the publisher code block.

anguillanneuf
anguillanneuf suggested changes Oct 12, 2018
View reviewed changes
Copy link
Contributor

@anguillanneuf anguillanneuf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, approved too quickly. Would need changes on publisher code block too.

@tseaver
Copy link
Contributor Author

tseaver commented Oct 12, 2018

@anguillanneuf

Oops, approved too quickly. Would need changes on publisher code block too.

See fee1735

@tseaver tseaver merged commit 987d410 into googleapis:master Oct 12, 2018
@tseaver tseaver deleted the 6189-pubsub-update_readme_subscriber_example branch October 12, 2018 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anguillanneuf anguillanneuf anguillanneuf approved these changes

@theacodes theacodes Awaiting requested review from theacodes

@crwilcox crwilcox Awaiting requested review from crwilcox

Assignees
No one assigned
Labels
api: pubsub Issues related to the Pub/Sub API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tseaver @anguillanneuf @googlebot