Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regenerate compute client #5416

Merged
merged 1 commit into from
Jun 5, 2019
Merged

Regenerate compute client #5416

merged 1 commit into from
Jun 5, 2019

Conversation

yoshi-automation
Copy link
Contributor

This PR was generated using Autosynth. 🌈

Here's the log from Synthtool:

synthtool > Executing /tmpfs/src/git/autosynth/working_repo/google-cloud-clients/google-cloud-compute/synth.py.
synthtool > Cloning discovery-artifact-manager.
synthtool > Running generator for gapic/google/compute/artman_compute.yaml.
synthtool > Ensuring dependencies.
synthtool > Pulling artman image.
0.22.0: Pulling from googleapis/artman
Digest: sha256:72f6287a42490bfe1609aed491f29411af21df3f744199fe8bb8d276c1fdf419
Status: Image is up to date for googleapis/artman:0.22.0
synthtool > Generated code into /home/kbuilder/.cache/synthtool/discovery-artifact-manager/artman-genfiles/java.
synthtool > Running java formatter on 1387 files
synthtool > Cleaned up 0 temporary directories.
synthtool > Wrote metadata to synth.metadata.

@yoshi-automation yoshi-automation requested a review from a team as a code owner June 5, 2019 17:40
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 5, 2019
chingor13
chingor13 reviewed Jun 5, 2019
View reviewed changes
...google-cloud-compute/src/main/java/com/google/cloud/compute/v1/stub/LicenseStubSettings.java
@@ -170,7 +170,7 @@ public LicenseStub createStub() throws IOException {

/** Returns the default service endpoint. */
public static String getDefaultEndpoint() {
return "https://compute.googleapis.com/compute/v1/projects/";
return "https://www.googleapis.com/compute/v1/projects/";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andreamlin Is this expected?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://www.googleapis.com/discovery/v1/apis/compute/v1/rest looks like they've changed it yeah.

@chingor13 chingor13 requested a review from andreamlin June 5, 2019 19:10
andreamlin
andreamlin approved these changes Jun 5, 2019
View reviewed changes
Copy link
Contributor

@andreamlin andreamlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andreamlin andreamlin merged commit b29dded into master Jun 5, 2019
@andreamlin andreamlin deleted the autosynth-compute branch June 5, 2019 19:38
@chingor13 chingor13 mentioned this pull request Jun 6, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chingor13 chingor13 chingor13 left review comments

@andreamlin andreamlin andreamlin approved these changes

Assignees

@andreamlin andreamlin

Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yoshi-automation @chingor13 @andreamlin @googlebot