Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add integration tests for snapshot read and resuming. #5242

Merged
merged 3 commits into from
Jun 4, 2019
Merged

Add integration tests for snapshot read and resuming. #5242

merged 3 commits into from
Jun 4, 2019

Conversation

mmladenovski
Copy link

The change adds the following integration tests:

  • Resuming by row offset when calling ReadRows.
  • Reading rows at different snapshots in time.

@tswast or @shollyman, please review.

CC: @kmjung , @aryann

@mmladenovski
Add integration tests for snapshot read and resuming.
9ea1eea 
The change adds the following integration tests:

* Resuming by row offset when calling ReadRows.
* Reading rows at different snapshots in time.
@mmladenovski mmladenovski requested a review from a team as a code owner May 30, 2019 18:32
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 30, 2019
@kmjung
Copy link

kmjung commented May 30, 2019

cc: @JesseLovelace

@sduskis sduskis added api: bigquery Issues related to the BigQuery API. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels May 31, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 31, 2019
@codecov
Copy link

codecov bot commented May 31, 2019 •
edited
Loading

Codecov Report

Merging #5242 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #5242   +/-   ##
=========================================
  Coverage     50.48%   50.48%           
  Complexity    23875    23875           
=========================================
  Files          2258     2258           
  Lines        227482   227482           
  Branches      24978    24978           
=========================================
  Hits         114834   114834           
  Misses       104029   104029           
  Partials       8619     8619

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ffdda3...83a7a95. Read the comment docs.

kmjung
kmjung reviewed Jun 3, 2019
View reviewed changes
...torage/src/test/java/com/google/cloud/bigquery/storage/v1beta1/it/ITBigQueryStorageTest.java
@@ -104,6 +151,57 @@ public void testSimpleRead() {
assertEquals(164_656, avroRowCount);
}

@Test
public void testSimpleReadAndResume() {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the end user use case for resume? Shouldn't this be handled transparently by the client?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kmjung , it is handled transparently by the client. The goal of this test is to explicitly verify it.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resuming by offset can also be used explicitly by clients in scenarios:

  1. The row progress per stream is stored in customers systems
  2. Customer pauses the stream reading for applying changes on their system.
  3. Customer resumes processing.

I thought it would be good to have an explicit tests for this functionality.

@shollyman shollyman added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 4, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 4, 2019
@shollyman
Copy link
Contributor

Kokoro - Test: Windows Java 8 failure is unrelated to changes (spanner flakes).

@shollyman shollyman merged commit 756b3d4 into googleapis:master Jun 4, 2019
@mmladenovski mmladenovski deleted the integration_tests branch June 4, 2019 18:11
@chingor13 chingor13 mentioned this pull request Jun 6, 2019
Merged
@tswast tswast mentioned this pull request Aug 6, 2019
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmjung kmjung kmjung left review comments

@sduskis sduskis sduskis left review comments

@shollyman shollyman shollyman approved these changes

Assignees
No one assigned
Labels
api: bigquery Issues related to the BigQuery API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mmladenovski @kmjung @shollyman @sduskis @googlebot @yoshi-kokoro