Bigtable: Add createUnsafe factory method in Mutation model #3800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
chingor13
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
igorbernstein2
requested changes
Oct 10, 2018
| } | ||
|
|
||
| private Mutation() {} | ||
| /** | ||
| * Creates Mutation object which allows setCell operation to set server side timestamp. |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| @@ -102,7 +114,9 @@ public Mutation setCell( | |||
| Validations.validateFamily(familyName); | |||
| Preconditions.checkNotNull(qualifier, "qualifier can't be null."); | |||
| Preconditions.checkNotNull(value, "value can't be null."); | |||
| Preconditions.checkArgument(timestamp != -1, "Serverside timestamps are not supported"); | |||
| if (!allowServersideTimestamp) { | |||
| Preconditions.checkArgument(timestamp != -1, "Serverside timestamps are not supported"); | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| .setCell( | ||
| "fake-family", | ||
| ByteString.copyFromUtf8("fake-qualifier"), | ||
| -1, |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
igorbernstein2
approved these changes
Oct 10, 2018
| /** | ||
| * Creates new instance of Mutation object. | ||
| * | ||
| * @return Mutation object. |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
chingor13
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add createUnsafe factory method in Mutation model.