Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify release process #3799

Merged
merged 6 commits into from
Oct 10, 2018
Merged

Conversation

chingor13
Copy link
Contributor

These maven config changes make it so you no longer need to edit the root pom.xml file as part of the release process.

  • Moved the gpg signing and nexus-sonatype-staging-plugin to the artifacts that are releasable. This plugin replaces the deploy goal.
  • Skip maven-deploy-plugin for non-releasable artifacts.
  • Changes order of modules because a deployable artifact must be last.

Only use the nexus-staging-maven-plugin on deployable assets.
Set skip to true for deployment on non-deployable assets.
@chingor13 chingor13 requested review from garrettjonesgoogle and a team October 10, 2018 18:19
@chingor13 chingor13 requested a review from pongad as a code owner October 10, 2018 18:19
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 10, 2018
Copy link
Member

@garrettjonesgoogle garrettjonesgoogle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool!!

@@ -679,7 +669,7 @@
<violationSeverity>error</violationSeverity>
<failsOnError>true</failsOnError>
<includeTestSourceDirectory>true</includeTestSourceDirectory>
<excludes>com/google/cloud/*/v*/**</excludes><!-- We need to exclude autogenerated code -->
<excludes>com/google/cloud/*/v*/**,</excludes><!-- We need to exclude autogenerated code -->

This comment was marked as spam.

This comment was marked as spam.

Copy link
Member

@garrettjonesgoogle garrettjonesgoogle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chingor13 chingor13 merged commit 76e09ee into googleapis:master Oct 10, 2018
@chingor13 chingor13 deleted the release-profile branch October 10, 2018 22:21
This was referenced Oct 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants