-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify release process #3799
Simplify release process #3799
Conversation
Only use the nexus-staging-maven-plugin on deployable assets. Set skip to true for deployment on non-deployable assets.
…clients and google-api-grpc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool!!
google-cloud-clients/pom.xml
Outdated
@@ -679,7 +669,7 @@ | |||
<violationSeverity>error</violationSeverity> | |||
<failsOnError>true</failsOnError> | |||
<includeTestSourceDirectory>true</includeTestSourceDirectory> | |||
<excludes>com/google/cloud/*/v*/**</excludes><!-- We need to exclude autogenerated code --> | |||
<excludes>com/google/cloud/*/v*/**,</excludes><!-- We need to exclude autogenerated code --> |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
These maven config changes make it so you no longer need to edit the root
pom.xml
file as part of the release process.deploy
goal.