Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spanner: Expand test coverage for ResultSets #3717

Merged
merged 4 commits into from
Oct 9, 2018
Merged

spanner: Expand test coverage for ResultSets #3717

merged 4 commits into from
Oct 9, 2018

Conversation

nithinsujir
Copy link

ResultSets coverage now at 99%.

@nsujir
spanner: Expand test coverage for ResultSets
ff9ffc9 
ResultSets coverage now at 99%.
@nithinsujir nithinsujir requested a review from pongad as a code owner September 21, 2018 15:36
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 21, 2018
@nithinsujir nithinsujir changed the title WIP: spanner: Expand test coverage for ResultSets spanner: Expand test coverage for ResultSets Sep 21, 2018
snehashah16
snehashah16 reviewed Sep 21, 2018
View reviewed changes
...loud-clients/google-cloud-spanner/src/test/java/com/google/cloud/spanner/ResultSetsTest.java

try {
rs.getStats();
fail("Exception expected");

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

...loud-clients/google-cloud-spanner/src/test/java/com/google/cloud/spanner/ResultSetsTest.java Outdated
@@ -34,11 +41,51 @@

@Test
public void resultSetIteration() {
double dval = 1.2;
String s = "s";
String byt = "101";

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

...loud-clients/google-cloud-spanner/src/test/java/com/google/cloud/spanner/ResultSetsTest.java
@@ -34,11 +41,51 @@

@Test
public void resultSetIteration() {

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

snehashah16
snehashah16 approved these changes Sep 26, 2018
View reviewed changes
Copy link
Contributor

@snehashah16 snehashah16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Please hold off on submitting this until DML PR is out.

...loud-clients/google-cloud-spanner/src/test/java/com/google/cloud/spanner/ResultSetsTest.java
@@ -34,11 +41,51 @@

@Test
public void resultSetIteration() {

This comment was marked as spam.

Sign in to view

...loud-clients/google-cloud-spanner/src/test/java/com/google/cloud/spanner/ResultSetsTest.java

try {
rs.getStats();
fail("Exception expected");

This comment was marked as spam.

Sign in to view

@nithinsujir nithinsujir changed the title spanner: Expand test coverage for ResultSets WIP: spanner: Expand test coverage for ResultSets Sep 26, 2018
@nithinsujir
Copy link
Author

Marking this WIP until DML changes are in.

@nithinsujir nithinsujir changed the title WIP: spanner: Expand test coverage for ResultSets spanner: Expand test coverage for ResultSets Oct 2, 2018
@nithinsujir
Copy link
Author

@pongad Merged DML changes. Turns out there is no impact because the getStats() that DML changed is in a different class than the one in this test.

This PR is ready to go.

@pongad
Copy link
Contributor

pongad commented Oct 2, 2018

We're transitioning ownership of this repo and I don't have write access anymore. @chingor13 @JesseLovelace can you help?

@chingor13
Copy link
Contributor

Does this need to go out with the spanner DML feature or can it wait until after the release is completed?

@nithinsujir
Copy link
Author

nithinsujir commented Oct 2, 2018 via email

@chingor13
Copy link
Contributor

SGTM

@chingor13 chingor13 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 2, 2018
@chingor13 chingor13 self-assigned this Oct 2, 2018
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 2, 2018
@chingor13 chingor13 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 9, 2018
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 9, 2018
@chingor13 chingor13 merged commit a5628af into googleapis:master Oct 9, 2018
This was referenced Oct 10, 2018
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snehashah16 snehashah16 snehashah16 approved these changes

@pongad pongad Awaiting requested review from pongad

Assignees

@chingor13 chingor13

Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@nithinsujir @pongad @chingor13 @snehashah16 @googlebot @kokoro-team @nsujir