Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move <reportPlugins> to <reporting><plugins> #3524

Merged
merged 8 commits into from
Oct 9, 2018
Merged

Move <reportPlugins> to <reporting><plugins> #3524

merged 8 commits into from
Oct 9, 2018

Conversation

andreamlin
Copy link
Contributor

@andreamlin andreamlin commented Aug 1, 2018 •
edited by chingor13
Loading

The build log is cluttered with messages of the sort:

Some problems were encountered while building the effective model for com.google.api.grpc:grpc-google-cloud-automl-v1beta1:jar:0.21.0
[WARNING] Reporting configuration should be done in <reporting> section, not in maven-site-plugin <configuration> as reportPlugins parameter.

Hopefully this shuts it down.

WIP while this is being verified.

Fixes #3205

@andreamlin andreamlin requested a review from pongad as a code owner August 1, 2018 22:49
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 1, 2018
@andreamlin andreamlin removed the request for review from pongad August 1, 2018 22:50
@andreamlin andreamlin changed the title Move <reportPlugins> to <reporting><plugins> Move <reportPlugins> to <reporting><plugins> (WIP) Aug 1, 2018
pongad
pongad reviewed Aug 9, 2018
View reviewed changes
google-cloud-clients/google-cloud-bigtable/pom.xml Outdated
@@ -110,7 +110,7 @@
</activation>
<properties>
<!-- add this to disable checking -->
<javadoc.opts>-Xdoclint:none</javadoc.opts>
<!--<javadoc.opts>-Xdoclint:none</javadoc.opts>-->

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@pongad
Copy link
Contributor

pongad commented Aug 9, 2018

Apart from comment above, LGTM

@andreamlin andreamlin changed the title Move <reportPlugins> to <reporting><plugins> (WIP) Move <reportPlugins> to <reporting><plugins> Aug 14, 2018
@chingor13 chingor13 merged commit ef2a88b into googleapis:master Oct 9, 2018
This was referenced Oct 10, 2018
Closed
Closed
chingor13 added a commit to chingor13/google-cloud-java that referenced this pull request Oct 10, 2018
@chingor13
Revert "Move <reportPlugins> to <reporting><plugins> (googleapis#3524)"
e57fb93 
This reverts commit ef2a88b.
@chingor13 chingor13 mentioned this pull request Oct 10, 2018
Merged
chingor13 added a commit that referenced this pull request Oct 10, 2018
@chingor13
Revert "Move <reportPlugins> to <reporting><plugins> (#3524)" (#3806)
a66e3b7 
This reverts commit ef2a88b.
@igorbernstein2 igorbernstein2 mentioned this pull request Nov 5, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igorbernstein2 igorbernstein2 igorbernstein2 left review comments

@pongad pongad pongad left review comments

@chingor13 chingor13 chingor13 approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@andreamlin @pongad @chingor13 @igorbernstein2 @googlebot