Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BigQuery: Standardizes region tags and adds query snippets from java-docs-samples #3180

Merged
merged 11 commits into from
Apr 24, 2018
Merged

BigQuery: Standardizes region tags and adds query snippets from java-docs-samples #3180

merged 11 commits into from
Apr 24, 2018

Conversation

alixhami
Copy link
Contributor

This PR:

  • Updates region tags to standard so they can be tracked with our sample tracking tool
  • Changes region tags that are Java-specific and only in reference docs to bigquery_java_untracked, because these do not need to be tracked in our sample tracking tool
  • Adds query samples from java-docs-samples so they can be deleted from that repo (reduces redundancy of samples)

@alixhami alixhami added the api: bigquery Issues related to the BigQuery API. label Apr 20, 2018
@alixhami alixhami requested review from tswast and pongad April 20, 2018 23:51
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 20, 2018
@alixhami alixhami mentioned this pull request Apr 20, 2018
Merged
tswast
tswast reviewed Apr 23, 2018
View reviewed changes
Copy link
Contributor

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 on the sample updates. Just a couple of comments there. Could you run the utilities/add_snippets_to_file.py script so that these sample updates make it into the JavaDocs?

...oud-examples/src/main/java/com/google/cloud/examples/bigquery/snippets/BigQuerySnippets.java Outdated
@@ -167,14 +174,14 @@ public Table updateTable(String datasetName, String tableName, String newFriendl
// [TARGET delete(String, DatasetDeleteOption...)]
// [VARIABLE "my_dataset_name"]
public Boolean deleteDataset(String datasetName) {
// [START deleteDataset]
// [START bigquery_java_untracked]

This comment was marked as spam.

Sign in to view

...oud-examples/src/main/java/com/google/cloud/examples/bigquery/snippets/BigQuerySnippets.java Outdated
// Allow results larger than the maximum response size.
// If true, a destination table must be set. See:
// https://cloud.google.com/bigquery/docs/writing-results#large-results
.setAllowLargeResults(true)

This comment was marked as spam.

Sign in to view

...oud-examples/src/main/java/com/google/cloud/examples/bigquery/snippets/BigQuerySnippets.java Outdated
// Print the results.
DateTimeFormatter formatter = ISODateTimeFormat.dateTimeNoMillis().withZoneUTC();
for (FieldValueList row : bigquery.query(queryConfig).iterateAll()) {
for (FieldValue val : row) {

This comment was marked as spam.

Sign in to view

@tswast
Copy link
Contributor

tswast commented Apr 23, 2018

The utilities/add_snippets_to_file.py script takes two arguments:

tswast
tswast approved these changes Apr 24, 2018
View reviewed changes
Copy link
Contributor

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it!

...oud-examples/src/main/java/com/google/cloud/examples/bigquery/snippets/BigQuerySnippets.java Outdated
@@ -174,14 +169,14 @@ public Table updateTable(String datasetName, String tableName, String newDescrip
// [TARGET delete(String, DatasetDeleteOption...)]
// [VARIABLE "my_dataset_name"]
public Boolean deleteDataset(String datasetName) {
// [START bigquery_java_untracked]
// [START ]

This comment was marked as spam.

Sign in to view

@tswast tswast merged commit c59f31d into googleapis:master Apr 24, 2018
@alixhami alixhami deleted the bq-standardize-region-tags branch April 24, 2018 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tswast tswast tswast approved these changes

@pongad pongad Awaiting requested review from pongad

Assignees
No one assigned
Labels
api: bigquery Issues related to the BigQuery API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alixhami @tswast @googlebot