From 08d7ad879372c3f0a9f9e0a8af648d5eae81d282 Mon Sep 17 00:00:00 2001 From: Chanseok Oh Date: Thu, 5 Aug 2021 13:58:54 -0400 Subject: [PATCH 1/3] Upgrade appengine-plugins-core --- .../tools/eclipse/test/dependencies/EclipseLoggingAdapter.java | 3 +-- .../tools/eclipse/util/FacetExistsPropertyTesterTest.java | 1 - pom.xml | 2 +- 3 files changed, 2 insertions(+), 4 deletions(-) diff --git a/plugins/com.google.cloud.tools.eclipse.test.dependencies/src/com/google/cloud/tools/eclipse/test/dependencies/EclipseLoggingAdapter.java b/plugins/com.google.cloud.tools.eclipse.test.dependencies/src/com/google/cloud/tools/eclipse/test/dependencies/EclipseLoggingAdapter.java index b289a016aa..c34a77ca7b 100644 --- a/plugins/com.google.cloud.tools.eclipse.test.dependencies/src/com/google/cloud/tools/eclipse/test/dependencies/EclipseLoggingAdapter.java +++ b/plugins/com.google.cloud.tools.eclipse.test.dependencies/src/com/google/cloud/tools/eclipse/test/dependencies/EclipseLoggingAdapter.java @@ -25,8 +25,7 @@ * An SLF4j facade for OSGi {@link LoggerFactory} and Eclipse {@link ExtendedLogService}. This class * is intended to be a replacement for other ExtendedLogService implementations. */ -public class EclipseLoggingAdapter extends LoggerDelegate - implements LoggerFactory, ExtendedLogService { +public class EclipseLoggingAdapter extends LoggerDelegate implements ExtendedLogService { public EclipseLoggingAdapter() { super(org.slf4j.LoggerFactory.getLogger(org.slf4j.Logger.ROOT_LOGGER_NAME)); diff --git a/plugins/com.google.cloud.tools.eclipse.util.test/src/com/google/cloud/tools/eclipse/util/FacetExistsPropertyTesterTest.java b/plugins/com.google.cloud.tools.eclipse.util.test/src/com/google/cloud/tools/eclipse/util/FacetExistsPropertyTesterTest.java index 5bb8f6cc8d..be951a919d 100644 --- a/plugins/com.google.cloud.tools.eclipse.util.test/src/com/google/cloud/tools/eclipse/util/FacetExistsPropertyTesterTest.java +++ b/plugins/com.google.cloud.tools.eclipse.util.test/src/com/google/cloud/tools/eclipse/util/FacetExistsPropertyTesterTest.java @@ -16,7 +16,6 @@ package com.google.cloud.tools.eclipse.util; -import com.google.cloud.tools.eclipse.util.FacetExistsPropertyTester; import org.junit.Assert; import org.junit.Test; diff --git a/pom.xml b/pom.xml index e25ca19ccf..66119b5af2 100644 --- a/pom.xml +++ b/pom.xml @@ -99,7 +99,7 @@ com.google.cloud.tools appengine-plugins-core - 0.8.1 + 0.9.5 com.google.guava guava - 28.1-jre + 30.0-jre From d1347c9e4a166d632d8d235618e5e0cb29f23c7f Mon Sep 17 00:00:00 2001 From: Chanseok Oh Date: Thu, 5 Aug 2021 16:35:59 -0400 Subject: [PATCH 3/3] Supporess DoNotMock errorprone warning --- .../tools/eclipse/googleapis/internal/GoogleApiFactoryTest.java | 1 + .../googleapis/internal/GoogleApiFactoryWithProxyServerTest.java | 1 + 2 files changed, 2 insertions(+) diff --git a/plugins/com.google.cloud.tools.eclipse.googleapis.test/src/com/google/cloud/tools/eclipse/googleapis/internal/GoogleApiFactoryTest.java b/plugins/com.google.cloud.tools.eclipse.googleapis.test/src/com/google/cloud/tools/eclipse/googleapis/internal/GoogleApiFactoryTest.java index b3f93c9a77..d9dafb0dbd 100644 --- a/plugins/com.google.cloud.tools.eclipse.googleapis.test/src/com/google/cloud/tools/eclipse/googleapis/internal/GoogleApiFactoryTest.java +++ b/plugins/com.google.cloud.tools.eclipse.googleapis.test/src/com/google/cloud/tools/eclipse/googleapis/internal/GoogleApiFactoryTest.java @@ -50,6 +50,7 @@ import org.mockito.Mock; import org.mockito.runners.MockitoJUnitRunner; +@SuppressWarnings("DoNotMock") @RunWith(MockitoJUnitRunner.class) public class GoogleApiFactoryTest { diff --git a/plugins/com.google.cloud.tools.eclipse.googleapis.test/src/com/google/cloud/tools/eclipse/googleapis/internal/GoogleApiFactoryWithProxyServerTest.java b/plugins/com.google.cloud.tools.eclipse.googleapis.test/src/com/google/cloud/tools/eclipse/googleapis/internal/GoogleApiFactoryWithProxyServerTest.java index 6225b3930e..1e6cd52fd6 100644 --- a/plugins/com.google.cloud.tools.eclipse.googleapis.test/src/com/google/cloud/tools/eclipse/googleapis/internal/GoogleApiFactoryWithProxyServerTest.java +++ b/plugins/com.google.cloud.tools.eclipse.googleapis.test/src/com/google/cloud/tools/eclipse/googleapis/internal/GoogleApiFactoryWithProxyServerTest.java @@ -43,6 +43,7 @@ import org.mockito.Mock; import org.mockito.runners.MockitoJUnitRunner; +@SuppressWarnings("DoNotMock") @RunWith(MockitoJUnitRunner.class) public class GoogleApiFactoryWithProxyServerTest {