Add GCS Action #121
Merged
Add GCS Action #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sethvargo
approved these changes
Jun 9, 2020
|
Taking a look at the failing test, it appears the SA being used for the int-tests is missing a required permission: "##[error]*** does not have storage.objects.create access to the Google Cloud Storage object." |
|
@craigdbarber I was working with @averikitsch to figure this out. The permissions do seem to be correct in the project, I was able to get this working on a different service account with the same role. |
averikitsch
reviewed
Jun 10, 2020
averikitsch
approved these changes
Jun 11, 2020
|
ping. Do you want to go ahead and merge this? |
|
@averikitsch sorry missed Craig's approval. I have merged it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replaces #55
fixes #32
Add a native GCS Upload Action using google-cloud/storage