Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: No 'batch_root' folder in tutorial notebook of vector search index #1406

Closed
1 task done
BanJeoker opened this issue Nov 14, 2024 · 4 comments
Closed
1 task done
Assignees

Comments

@BanJeoker
Copy link

File Name

generative-ai/blob/main/embeddings/intro-textemb-vectorsearch.ipynb

What happened?

In this sentence, Then, create a new Cloud Storage bucket and copy the file to it. BUCKET_URI = f"gs://{PROJECT_ID}-embvs-tutorial-{UID}" ! gsutil mb -l $LOCATION -p {PROJECT_ID} {BUCKET_URI} ! gsutil cp questions.json {BUCKET_URI}

You need to create a 'batch_root' folder in the bucket you just created, otherwise the index created will not use that json file, it will be an empty index.

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@BanJeoker BanJeoker changed the title [Bug]: No 'batch_root' folder in tutorial notebook of vertex search index [Bug]: No 'batch_root' folder in tutorial notebook of vector search index Nov 14, 2024
@kazunori279
Copy link
Contributor

Hi @BanJeoker , did you actually ran the notebook and saw an empty index created? I've been creating index without the batch_root folder for many times, and haven't seen any issues..

@BanJeoker
Copy link
Author

@kazunori279 yes I ran the notebook, the index can be created without the batch_root folder, however, in that case, the index will have no dense count, a query will return empty list back. Also, isn't creating the batch_root folder emphasized in the official documentation here

https://cloud.google.com/vertex-ai/docs/vector-search/setup/format-st
Screenshot 2024-11-15 at 6 40 41 AM

Thanks

@kazunori279
Copy link
Contributor

Hi @BanJeoker , I just went through the notebook from the start, and got a proper result:

Screenshot 2024-11-19 at 16 32 59

So the use of the batch_root folder may not be the cause why you are getting an empty result. But agree, it's better to add the use of batch_root folder to this sample to be consistent with the document.

@BanJeoker
Copy link
Author

thank you Kaz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants