Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

storage/file#getSignedUrl: It shouldn't be necessary to add newline to end of extensionHeaders #1316

Closed
aknuds1 opened this issue May 14, 2016 · 1 comment
Closed

storage/file#getSignedUrl: It shouldn't be necessary to add newline to end of extensionHeaders #1316

aknuds1 opened this issue May 14, 2016 · 1 comment
Assignees
@stephenplusplus
Labels
api: storage Issues related to the Cloud Storage API.

Comments

@aknuds1
Copy link
Contributor

aknuds1 commented May 14, 2016

The way storage/file#getSignedUrl computes the signature, it is necessary for the API client to end extensionHeaders with a newline, otherwise it won't correspond to the server's calculated signature. This should be handled automatically by gcloud-node.
This was referenced May 14, 2016
Closed
Closed
@stephenplusplus stephenplusplus added enhancement api: storage Issues related to the Cloud Storage API. labels May 14, 2016
@stephenplusplus
Copy link
Contributor

Fixed via 17e510b.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stephenplusplus stephenplusplus

Labels
api: storage Issues related to the Cloud Storage API.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aknuds1 @stephenplusplus