Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support CloudEvent as triggers in Functions Frameworks #141

Closed
anguillanneuf opened this issue Aug 5, 2021 · 3 comments
Closed

Support CloudEvent as triggers in Functions Frameworks #141

anguillanneuf opened this issue Aug 5, 2021 · 3 comments

Comments

@anguillanneuf
Copy link
Member

See #23 (comment)

@frankie567

@di
Copy link
Member

di commented Aug 5, 2021

If I'm understanding correctly, this is already supported (added in #56) -- or am I missing something?

@anguillanneuf
Copy link
Member Author

anguillanneuf commented Aug 11, 2021

Ohh, you are right.

I think the issue should be to update the Pub/Sub quickstart to use (event, context):

https://github.com/GoogleCloudPlatform/functions-framework-python#quickstart-pubsub-emulator

Hm, but that is not feasible because the Pub/Sub emulator does not send messages formatted in CloudEvent and we can't change that. Okay to close if no user comment.

@di
Copy link
Member

di commented Aug 11, 2021

I'll close this and reopen #23.

@di di closed this as completed Aug 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants