chore: add conformance test coverage for typed function signature #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garethgeorge
force-pushed
the
garethgeorge/typed
branch
from
cf064a4 to
165c7ea
Compare
KaylaNguyen
approved these changes
Jun 26, 2023
garethgeorge
force-pushed
the
garethgeorge/typed
branch
from
165c7ea to
8febcc9
Compare
|
Thanks Kayla -- good catch. Looks like the run_conformance_test isn't actually used by the github action workflow (confusing). I'll go ahead and update the github actions workflow in this PR aswell. |
garethgeorge
force-pushed
the
garethgeorge/typed
branch
2 times, most recently
from
489ce26 to
77ab191
Compare
garethgeorge
force-pushed
the
garethgeorge/typed
branch
from
77ab191 to
6a36da7
Compare
|
All tests passing now with typed function conformance tests included. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds conformance testing of the typed function signature.