_make_schema fix #99
_make_schema fix #99
Conversation
|
@DtStry can you provide some pointer code snippets to show how this was tested? |
I was simply calling bulk_create_intent_from_dataframe() with 'advanced' option and it throw this error |
There was a problem hiding this comment.
The changes proposed here are actually obsolete with the new data structure returned by Intents.bulk_intent_to_df(mode=advanced)
Instead of merging these in, the entire bulk_create_intent_from_dataframe needs to be refactored and/or reimagined. We should align all of our dataframe schemas appropriately so that the outputs of a method in one part of the library can be seamlessly used as inputs in another part of the library.
Since we have already refactored the DataFrame output in the Intents file, I suggest we realign here.
cc: @MRyderOC re: schema enforcements
|
Closing this PR in lieu of the changes we've made to these files already. |
No description provided.