You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This broke one of my customers in production. Underlying code uses parameter location_id. The documentation for this function still calls the argument "location_id", so I'm guessing this was an inadvertent change. Is there unit testing to catch/prevent this kind of thing?
The text was updated successfully, but these errors were encountered:
@xsgbloom this was an inadvertent change.
I will revert it back to the original.
Re: unit tests, unfortunately none are running on this file yet.
We're in the process of building out unit tests for all files to prevent breaks like this from happening.
dfcx-scrapi/src/dfcx_scrapi/core/agents.py
Line 89 in 1c9f813
This broke one of my customers in production. Underlying code uses parameter location_id. The documentation for this function still calls the argument "location_id", so I'm guessing this was an inadvertent change. Is there unit testing to catch/prevent this kind of thing?
The text was updated successfully, but these errors were encountered: