Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

list_agents function argument location_id has changed to location #138

Closed
xsgbloom opened this issue Aug 14, 2023 · 1 comment · Fixed by #139
Closed

list_agents function argument location_id has changed to location #138

xsgbloom opened this issue Aug 14, 2023 · 1 comment · Fixed by #139

Comments

@xsgbloom
Copy link

location: str = None) -> List[types.Agent]:

This broke one of my customers in production. Underlying code uses parameter location_id. The documentation for this function still calls the argument "location_id", so I'm guessing this was an inadvertent change. Is there unit testing to catch/prevent this kind of thing?

@kmaphoenix
Copy link
Member

@xsgbloom this was an inadvertent change.
I will revert it back to the original.

Re: unit tests, unfortunately none are running on this file yet.
We're in the process of building out unit tests for all files to prevent breaks like this from happening.

@kmaphoenix kmaphoenix linked a pull request Aug 17, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants