Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug/misc #113

Merged
merged 8 commits into from
Mar 27, 2023
Merged

Bug/misc #113

merged 8 commits into from
Mar 27, 2023

Conversation

MRyderOC
Copy link
Collaborator

Miscellaneous bug fixes: BUG #110 , BUG #111, BUG #112

@MRyderOC MRyderOC added the bug Something isn't working label Feb 24, 2023
@MRyderOC MRyderOC requested a review from kmaphoenix February 24, 2023 20:55
@MRyderOC MRyderOC linked an issue Feb 24, 2023 that may be closed by this pull request
[BUG] "APPEND" behavior in build_response method on webhook_util #112
Closed
@MRyderOC MRyderOC marked this pull request as draft March 3, 2023 03:40
This was linked to issues Mar 3, 2023
[BUG] Intent builder adds a space before TP parts that start with an apostrophe when adding a new TP #114
Closed
[BUG] KeyError in route_groups_to_dataframe for special pages #110
Closed
[BUG] update_webhook doesn't work properly when you pass a webhook_obj #111
Open
@MRyderOC MRyderOC marked this pull request as ready for review March 15, 2023 17:54
kmaphoenix
kmaphoenix requested changes Mar 27, 2023
View reviewed changes
Copy link
Member

@kmaphoenix kmaphoenix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the update_webhook patch is not necessary based on my other comment.
Everything else LGTM

@MRyderOC
Copy link
Collaborator Author

Thanks @kmaphoenix for your review and your time. Per our discussion, changes to the update_webhook have been reverted. So, it's safe to merge for now. Further action needs to be taken upon update_TYPE due to builders.

@MRyderOC MRyderOC requested a review from kmaphoenix March 27, 2023 20:46
kmaphoenix
kmaphoenix approved these changes Mar 27, 2023
View reviewed changes
Copy link
Member

@kmaphoenix kmaphoenix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kmaphoenix kmaphoenix merged commit 5c2a450 into main Mar 27, 2023
@kmaphoenix kmaphoenix deleted the bug/misc branch March 27, 2023 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmaphoenix kmaphoenix kmaphoenix approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
2 participants
@MRyderOC @kmaphoenix