Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore context in go-fuse Lookup method #2260

Closed
enocom opened this issue Jul 3, 2024 · 0 comments · Fixed by #2268
Closed

Ignore context in go-fuse Lookup method #2260

enocom opened this issue Jul 3, 2024 · 0 comments · Fixed by #2268
Assignees
@jackwotherspoon
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@enocom
Copy link
Member

enocom commented Jul 3, 2024 •
edited
Loading

On heavy use, the go-fuse library will cancel a context (perhaps due to an interrupt). Rather than handle interrupts, we should ignore them and let the underlying Dialer finish its job.

https://github.com/GoogleCloudPlatform/cloud-sql-proxy/blob/main/internal/proxy/proxy_other.go#L102

This would remove the need for GoogleCloudPlatform/cloud-sql-go-connector#831.

Cf. hanwen/go-fuse#452
@enocom enocom added priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: cleanup An internal cleanup or hygiene concern. labels Jul 3, 2024
@enocom enocom mentioned this issue Jul 4, 2024
Closed
@enocom enocom added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. and removed priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: cleanup An internal cleanup or hygiene concern. labels Jul 10, 2024
@jackwotherspoon jackwotherspoon mentioned this issue Jul 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jackwotherspoon jackwotherspoon

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: ignore go-fuse ctx in Lookup GoogleCloudPlatform/cloud-sql-proxy
2 participants
@enocom @jackwotherspoon