Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proxy process should exit when a FUSE instance gets an error when accepting a connection #2256

Closed
hessjcg opened this issue Jun 26, 2024 · 1 comment · Fixed by #2257
Closed

Proxy process should exit when a FUSE instance gets an error when accepting a connection #2256

hessjcg opened this issue Jun 26, 2024 · 1 comment · Fixed by #2257
Assignees
@hessjcg
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@hessjcg
Copy link
Collaborator

hessjcg commented Jun 26, 2024 •
edited
Loading

When the proxy tries to accept a connection, and then accept() returns an error, then the proxy process exits. However, fuse-configured connections do not to that. Instead, the proxy continues to run.

Update the fuse code so that the proxy exits when a fuse-configured connection fails to accept an incoming connection.
@hessjcg hessjcg added priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Jun 26, 2024
@hessjcg hessjcg changed the title Proxy process when a FUSE instance gets an error when accepting a connection Proxy process should exit when a FUSE instance gets an error when accepting a connection Jun 26, 2024
@enocom enocom added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. and removed priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Jun 26, 2024
@hessjcg hessjcg mentioned this issue Jul 10, 2024
Merged
@hessjcg
Copy link
Collaborator Author

hessjcg commented Jul 10, 2024

Fixed by #2257

@hessjcg hessjcg closed this as completed Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hessjcg hessjcg

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: exit when FUSE errors on accept GoogleCloudPlatform/cloud-sql-proxy
2 participants
@enocom @hessjcg