fix: return correct exit code on SIGTERM #1530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the client closes cleanly and max-sigterm-delay is enabled, the Proxy will exit with a 0 exit code on SIGTERM or SIGINT. Otherwise, the Proxy will exit with 143 (SIGTERM) or 130 (SIGINT).
enocom
changed the title
kurtisvg
changed the title
kurtisvg
approved these changes
Nov 9, 2022
enocom
added a commit
to GoogleCloudPlatform/alloydb-auth-proxy
that referenced
this pull request
Jan 15, 2023
enocom
added a commit
to GoogleCloudPlatform/alloydb-auth-proxy
that referenced
this pull request
Jan 18, 2023
enocom
added a commit
to GoogleCloudPlatform/alloydb-auth-proxy
that referenced
this pull request
Jan 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SIGTERM (15) is 128+15=143 (not 137).
See https://tldp.org/LDP/abs/html/exitcodes.html and https://komodor.com/learn/exit-codes-in-containers-and-kubernetes-the-complete-guide/ for details.
Fixes #1529.