feat: Adds Workload interface to access PodSpec for all workload types #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…types Provide a consistent interface Workload and implementations that can access the PodSpec and other common k8s data structure for Pod, Deployment, StatefulSet, DaemonSet, Job, and CronJob.
enocom
requested changes
Sep 21, 2022
internal/workload.go
Outdated
| "sigs.k8s.io/controller-runtime/pkg/client" | ||
| ) | ||
|
|
||
| // Workload interface a standard way to access the pod definition for the |
internal/workload.go
Outdated
| // necessary configuration and other details before it starts, or if the | ||
| // configuration changes. | ||
| type Workload interface { | ||
| GetPodSpec() corev1.PodSpec |
There was a problem hiding this comment.
This should just be PodSpec. Cf. https://go.dev/doc/effective_go#Getters
internal/workload.go
Outdated
| type Workload interface { | ||
| GetPodSpec() corev1.PodSpec | ||
| SetPodSpec(spec corev1.PodSpec) | ||
| GetObject() client.Object |
There was a problem hiding this comment.
Same thing here: Object will do.
internal/workload_test.go
Outdated
| }, | ||
| } | ||
|
|
||
| t.Parallel() |
There was a problem hiding this comment.
Unnecessary until we have tests that aren't running fast.
internal/workload_test.go
Outdated
| } | ||
|
|
||
| // mustMakeWorkload is shorthand to create workload test inputs | ||
| func mustMakeWorkload(kind string, ns string, name string, l ...string) Workload { |
There was a problem hiding this comment.
This should take a *testing.T so you can fail the test rather than kill the process.
internal/workload_test.go
Outdated
| desc: "match kind, namespace, and labels", | ||
| sel: cloudsqlapi.WorkloadSelectorSpec{ | ||
| Kind: "Pod", | ||
| Name: "", |
There was a problem hiding this comment.
Remember the zero value is already an empty string.
internal/workload_test.go
Outdated
| { | ||
| desc: "match namespace, and labels", | ||
| sel: cloudsqlapi.WorkloadSelectorSpec{ | ||
| Kind: "", |
internal/workload_test.go
Outdated
| { | ||
| desc: "match namespace, and label expression", | ||
| sel: cloudsqlapi.WorkloadSelectorSpec{ | ||
| Kind: "", |
internal/workload_test.go
Outdated
| case "DaemonSet": | ||
| v = &DaemonSetWorkload{DaemonSet: &appsv1.DaemonSet{TypeMeta: metav1.TypeMeta{Kind: "DaemonSet"}}} | ||
| default: | ||
| log.Fatalf("Workload kind %s not supported", kind) |
There was a problem hiding this comment.
t is not in this context.
internal/workload_test.go
Outdated
| v.GetObject().SetName(name) | ||
| if len(l) > 0 { | ||
| if len(l)%2 != 0 { | ||
| log.Fatalf("labels list must have an even number of elements") |
enocom
approved these changes
Sep 21, 2022
This was referenced Oct 12, 2022
This was referenced Dec 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide a consistent interface Workload and implementations that can access the PodSpec and other common k8s data structure for Pod, Deployment, StatefulSet, DaemonSet, Job, and CronJob.