fix!: remove Namespace field from AuthProxyWorkloadSelector #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hessjcg
changed the title
enocom
approved these changes
Dec 19, 2022
hessjcg
pushed a commit
that referenced
this pull request
Jan 18, 2023
0.2.0 (2023-01-18) BREAKING CHANGES - remove Namespace field from AuthProxyWorkloadSelector (#168) Bug Fixes - remove Namespace field from AuthProxyWorkloadSelector (#168) (7bcc27d) - Update installer.sh to use helm for cert-manager (#163) (62fc5dc), closes #157 Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Release PR Generate Bot action release-please[bot] <release-please[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For security, AuthProxyWorkload resources are only allowed to affect workloads running
in the same namespace. This prevents one AuthProxyWorkload in one namespace from affecting
a workload in a different namespace.
This change removes the WorkloadSelectorSpec.Namespace field and associated code that allowed
cross-namespace workload selection.