fix: remove unsupported CRD fields and associated code from the project. #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hessjcg
force-pushed
the
fix-prune-crd
branch
from
522ebb6 to
cead5e9
Compare
hessjcg
force-pushed
the
fix-prune-crd
branch
from
cead5e9 to
3af0869
Compare
enocom
approved these changes
Dec 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes fields from the CRD and associated code that converts those fields into
configuration on the proxy container. I removed fields that were unused in existing code
(like FUSE), fields that were unnecessary for minimum viable use of the proxy (like
telemetry args), and fields related to unix sockets, since that connection method
does not yet have an automated e2e test, and proxy V2 preview 4 does not use the
?unix-socket=/pathexactly as expected.