From b08c2dc945dd479ac3ae925b878da1745f4a19c7 Mon Sep 17 00:00:00 2001 From: Vipul Joshi <59138092+imVipul3000@users.noreply.github.com> Date: Sun, 11 Feb 2024 22:48:15 +0530 Subject: [PATCH 1/9] Removed default value for region/location from modules --- modules/data-catalog-policy-tag/variables.tf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/data-catalog-policy-tag/variables.tf b/modules/data-catalog-policy-tag/variables.tf index a41990b91a..a39eab6754 100644 --- a/modules/data-catalog-policy-tag/variables.tf +++ b/modules/data-catalog-policy-tag/variables.tf @@ -71,7 +71,7 @@ variable "iam_bindings_additive" { variable "location" { description = "Data Catalog Taxonomy location." type = string - default = "eu" + default = "" } variable "name" { From beb20cd26fbe0b29a889e593cd8f623a7eebf564 Mon Sep 17 00:00:00 2001 From: Vipul Joshi <59138092+imVipul3000@users.noreply.github.com> Date: Sun, 11 Feb 2024 22:50:01 +0530 Subject: [PATCH 2/9] Remove default value for region/location from modules --- modules/gcs/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/gcs/README.md b/modules/gcs/README.md index 539d82ce6a..0df4b0e39c 100644 --- a/modules/gcs/README.md +++ b/modules/gcs/README.md @@ -29,7 +29,7 @@ module "kms" { source = "./fabric/modules/kms" project_id = var.project_id keyring = { - location = "europe" # location of the KMS must match location of the bucket + location = "var.location" # location of the KMS must match location of the bucket name = "test" } keys = { From 3d2bd6e25763a19e42e545f4a225da56e7a3af98 Mon Sep 17 00:00:00 2001 From: Vipul Joshi <59138092+imVipul3000@users.noreply.github.com> Date: Sun, 11 Feb 2024 22:50:44 +0530 Subject: [PATCH 3/9] Remove default value for region/location from modules --- modules/gcs/variables.tf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/gcs/variables.tf b/modules/gcs/variables.tf index de8a6abd83..9baf8d37a3 100644 --- a/modules/gcs/variables.tf +++ b/modules/gcs/variables.tf @@ -149,7 +149,7 @@ variable "lifecycle_rules" { variable "location" { description = "Bucket location." type = string - default = "EU" + default = "" } variable "logging_config" { From 7f54a1983de389e09db3330033012ea653910ad4 Mon Sep 17 00:00:00 2001 From: Vipul Joshi <59138092+imVipul3000@users.noreply.github.com> Date: Sun, 11 Feb 2024 22:52:43 +0530 Subject: [PATCH 4/9] Remove default value for region/location from modules --- modules/container-registry/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/container-registry/README.md b/modules/container-registry/README.md index a5748e2aeb..4ad5b01a15 100644 --- a/modules/container-registry/README.md +++ b/modules/container-registry/README.md @@ -8,7 +8,7 @@ This module simplifies the creation of GCS buckets used by Google Container Regi module "container_registry" { source = "./fabric/modules/container-registry" project_id = "myproject" - location = "EU" + location = var.region iam = { "roles/storage.admin" = ["group:cicd@example.com"] } From 992d7667e78c8b7aa96c2e1a4a5f5d57d41b73a7 Mon Sep 17 00:00:00 2001 From: Vipul Joshi <59138092+imVipul3000@users.noreply.github.com> Date: Sun, 11 Feb 2024 22:54:46 +0530 Subject: [PATCH 5/9] Remove default value for region/location from modules --- modules/bigquery-dataset/variables.tf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/bigquery-dataset/variables.tf b/modules/bigquery-dataset/variables.tf index 5deb2d24c7..27ec535162 100644 --- a/modules/bigquery-dataset/variables.tf +++ b/modules/bigquery-dataset/variables.tf @@ -109,7 +109,7 @@ variable "labels" { variable "location" { description = "Dataset location." type = string - default = "EU" + default = "" } variable "materialized_views" { From 59c23728976752f14300851e74a56fddc795408c Mon Sep 17 00:00:00 2001 From: Vipul Joshi <59138092+imVipul3000@users.noreply.github.com> Date: Sun, 11 Feb 2024 22:57:59 +0530 Subject: [PATCH 6/9] Remove default value for region/location from modules --- modules/bigquery-dataset/variables.tf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/bigquery-dataset/variables.tf b/modules/bigquery-dataset/variables.tf index 27ec535162..d546365c43 100644 --- a/modules/bigquery-dataset/variables.tf +++ b/modules/bigquery-dataset/variables.tf @@ -109,7 +109,7 @@ variable "labels" { variable "location" { description = "Dataset location." type = string - default = "" + default = null } variable "materialized_views" { From b16e76be648d170f476aeb201c664950b270ca11 Mon Sep 17 00:00:00 2001 From: Vipul Joshi <59138092+imVipul3000@users.noreply.github.com> Date: Sun, 11 Feb 2024 22:58:27 +0530 Subject: [PATCH 7/9] Remove default value for region/location from modules --- modules/container-registry/variables.tf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/container-registry/variables.tf b/modules/container-registry/variables.tf index 9a5709e967..8855bae5d9 100644 --- a/modules/container-registry/variables.tf +++ b/modules/container-registry/variables.tf @@ -23,7 +23,7 @@ variable "iam" { variable "location" { description = "Registry location. Can be US, EU, ASIA or empty." type = string - default = "" + default = null } variable "project_id" { From 3c6ef4f0149adae6a4ef644302edc5f3b9a74da0 Mon Sep 17 00:00:00 2001 From: Vipul Joshi <59138092+imVipul3000@users.noreply.github.com> Date: Sun, 11 Feb 2024 22:59:20 +0530 Subject: [PATCH 8/9] Remove default value for region/location from modules --- modules/gcs/variables.tf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/gcs/variables.tf b/modules/gcs/variables.tf index 9baf8d37a3..cd0d9e6cbe 100644 --- a/modules/gcs/variables.tf +++ b/modules/gcs/variables.tf @@ -149,7 +149,7 @@ variable "lifecycle_rules" { variable "location" { description = "Bucket location." type = string - default = "" + default = null } variable "logging_config" { From 2f43151a8c048a71c59e388e945935e2f542f92a Mon Sep 17 00:00:00 2001 From: Vipul Joshi <59138092+imVipul3000@users.noreply.github.com> Date: Sun, 11 Feb 2024 23:00:04 +0530 Subject: [PATCH 9/9] Remove default value for region/location from modules --- modules/data-catalog-policy-tag/variables.tf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/data-catalog-policy-tag/variables.tf b/modules/data-catalog-policy-tag/variables.tf index a39eab6754..1f30b85b7e 100644 --- a/modules/data-catalog-policy-tag/variables.tf +++ b/modules/data-catalog-policy-tag/variables.tf @@ -71,7 +71,7 @@ variable "iam_bindings_additive" { variable "location" { description = "Data Catalog Taxonomy location." type = string - default = "" + default = null } variable "name" {