VPC-SC module does not enforce service filtering on ingress policies while using factories

[karpok78]

There seems to be a typo in the factory.tf file of the vpc-sc module.

Starting line 67 :

   ingress_policies = {
      for k, v in local._data.ingress_policies : k => {
        from = merge({
          access_levels = []
          identity_type = null
          identities    = null
          resources     = []
        }, try(v.from, {}))
        to = {
          operations = [
            for o in try(v.operations, []) : merge({
              method_selectors     = []
              permission_selectors = []
              service_name         = null
            }, o)
          ]
          resources = try(v.to.resources, [])
        }
      }
    }

The operations parameter is looping on v.operations instead of v.to.operations
This results in the service filters not to be applied on the policies.

[ludoo]

Great find, I had fixed it at a customer and forgot to bring back the change here. Will send a PR shortly, thanks for flagging.