Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discuss new design for billing alerts in factories #1779

Closed
ludoo opened this issue Oct 19, 2023 · 1 comment
Closed

Discuss new design for billing alerts in factories #1779

ludoo opened this issue Oct 19, 2023 · 1 comment
Assignees

Comments

@ludoo
Copy link
Collaborator

ludoo commented Oct 19, 2023

Following up on #1628 where @gustavovalverde raised the issue of billing alerts missing from the new project factory.

We recently created a new billing account module and moved billing alerts functionality inside it, so we are now ready to look at how to reimplement that functionality in factories.

My preference would be to add billing alert factory support to the billing account module, so alerts can be specified via a dedicated set of yaml files, and then either referencing existing alerts from the project factory, or combining it so the project data source can feed and populate the billling alerts data source.

@ludoo ludoo self-assigned this Oct 20, 2023
@ludoo
Copy link
Collaborator Author

ludoo commented Nov 1, 2023

A billing alert factory was added to the billing module a few days ago. We are planning an overhaul of factories across the whole repo, closing this for now since billing is done.

@ludoo ludoo closed this as completed Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant