From 9c1eb24fd992a4ea565f2d6e7faf67e69b3da394 Mon Sep 17 00:00:00 2001
From: Ludovico Magnocavallo <ludomagno@google.com>
Date: Sun, 22 Mar 2020 13:31:46 +0100
Subject: [PATCH] scheduled cloud function module: allow disabling schedule

---
 modules/__experimental/cloud-function-scheduled/README.md    | 2 +-
 modules/__experimental/cloud-function-scheduled/main.tf      | 1 +
 modules/__experimental/cloud-function-scheduled/variables.tf | 2 +-
 3 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/modules/__experimental/cloud-function-scheduled/README.md b/modules/__experimental/cloud-function-scheduled/README.md
index beeb88cf70..df1edce00d 100644
--- a/modules/__experimental/cloud-function-scheduled/README.md
+++ b/modules/__experimental/cloud-function-scheduled/README.md
@@ -28,7 +28,7 @@ module "function" {
 | *function_config* | Cloud function configuration. | <code title="object&#40;&#123;&#10;entry_point &#61; string&#10;instances   &#61; number&#10;memory      &#61; number&#10;runtime     &#61; string&#10;timeout     &#61; number&#10;&#125;&#41;">object({...})</code> |  | <code title="&#123;&#10;entry_point &#61; &#34;main&#34;&#10;instances   &#61; 1&#10;memory      &#61; 256&#10;runtime     &#61; &#34;python37&#34;&#10;timeout     &#61; 180&#10;&#125;">...</code> |
 | *prefixes* | Optional prefixes for resource ids, null prefixes will be ignored. | <code title="object&#40;&#123;&#10;bucket          &#61; string&#10;function        &#61; string&#10;job             &#61; string&#10;service_account &#61; string&#10;topic           &#61; string&#10;&#125;&#41;">object({...})</code> |  | <code title="">null</code> |
 | *region* | Region used for all resources. | <code title="">string</code> |  | <code title="">us-central1</code> |
-| *schedule_config* | Cloud function scheduler job configuration, leave data null to pass the name variable. | <code title="object&#40;&#123;&#10;pubsub_data &#61; string&#10;schedule    &#61; string&#10;time_zone   &#61; string&#10;&#125;&#41;">object({...})</code> |  | <code title="&#123;&#10;schedule    &#61; &#34;&#42;&#47;10 &#42; &#42; &#42; &#42;&#34;&#10;pubsub_data &#61; null&#10;time_zone   &#61; &#34;UTC&#34;&#10;&#125;">...</code> |
+| *schedule_config* | Cloud function scheduler job configuration, leave data null to pass the name variable, set schedule to null to disable schedule. | <code title="object&#40;&#123;&#10;pubsub_data &#61; string&#10;schedule    &#61; string&#10;time_zone   &#61; string&#10;&#125;&#41;">object({...})</code> |  | <code title="&#123;&#10;schedule    &#61; &#34;&#42;&#47;10 &#42; &#42; &#42; &#42;&#34;&#10;pubsub_data &#61; null&#10;time_zone   &#61; &#34;UTC&#34;&#10;&#125;">...</code> |
 | *service_account_iam_roles* | IAM roles assigned to the service account at the project level. | <code title="list&#40;string&#41;">list(string)</code> |  | <code title="">[]</code> |
 
 ## Outputs
diff --git a/modules/__experimental/cloud-function-scheduled/main.tf b/modules/__experimental/cloud-function-scheduled/main.tf
index ca197f98b1..0d3f03ff5d 100644
--- a/modules/__experimental/cloud-function-scheduled/main.tf
+++ b/modules/__experimental/cloud-function-scheduled/main.tf
@@ -46,6 +46,7 @@ resource "google_pubsub_topic" "topic" {
 }
 
 resource "google_cloud_scheduler_job" "job" {
+  count = var.schedule_config.schedule == null ? 0 : 1
   project   = var.project_id
   region    = var.region
   name      = lookup(local.prefixes, "job", var.name)
diff --git a/modules/__experimental/cloud-function-scheduled/variables.tf b/modules/__experimental/cloud-function-scheduled/variables.tf
index 6a33f37f2c..78bb4b8cac 100644
--- a/modules/__experimental/cloud-function-scheduled/variables.tf
+++ b/modules/__experimental/cloud-function-scheduled/variables.tf
@@ -75,7 +75,7 @@ variable "region" {
 }
 
 variable "schedule_config" {
-  description = "Cloud function scheduler job configuration, leave data null to pass the name variable."
+  description = "Cloud function scheduler job configuration, leave data null to pass the name variable, set schedule to null to disable schedule."
   type = object({
     pubsub_data = string
     schedule    = string