-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Misleading log message when app.yaml and appengine-web.xml file are missing #990
Comments
Maybe we could throw an exception if the xml and yaml configuration were not found? Right now the yaml stager is used in that case |
Makes sense, and user contributions are always appreciated. |
Could I take this issue if you don't mind : ) |
Sure. |
Thanks @meltsufin , I'm working on it. ( Just out of curiosity, what's the meaning of label PR has been filed, could you be so kind as to take a look on it ^_^ |
|
If
app.yaml
andappengine-web.xml
file are missing then we get "Detected App Engine app.yaml based application." log message. I think we could log another message in such case, because this one is misleading.https://github.com/GoogleCloudPlatform/app-maven-plugin/blob/master/src/main/java/com/google/cloud/tools/maven/deploy/Deployer.java#L44
The text was updated successfully, but these errors were encountered: