-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Listener Issue #142
Comments
Thank you! Just released |
I'm sorry but I don't understand this change.
No useCapture=true third argument there (and useCapture defaults to false). |
You're right. I didn't realize that the link went to outdated code. Sorry. |
No problem. Thank you for the quick response and of course, for your very useful library. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hello! Thanks for your work. Helped me a lot. There is a small issue when you are removing the event listener for window focus. As it was registered with useCapture = true, it should be unregistered using also useCapture = true argument.
https://github.com/GoogleChromeLabs/browser-fs-access/blame/5d8a551af106121d010c1c50ca4a15d3cb0b189d/src/legacy/file-open.mjs#LL32
The text was updated successfully, but these errors were encountered: