Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Observer callbacks should be deferred until after activation #271

Closed
philipwalton opened this issue Oct 19, 2022 · 0 comments · Fixed by #282
Closed

Observer callbacks should be deferred until after activation #271

philipwalton opened this issue Oct 19, 2022 · 0 comments · Fixed by #282

Comments

@philipwalton
Copy link
Member

For prerendered pages, in Chrome's current implementation it will always defer running any Performance Observer callbacks until after the page has been activated.

However, I'm not sure if we can guarantee that will always be the case (spec changes, browser bugs, etc.), so I think it makes sense to defer handling any Performance Observer callbacks until after activation.

If callbacks are handled prior to activation then activationStart will always be 0, and thus any calculations made using it will be incorrect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant