Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getEntriesByName is not supported in some versions of Opera #159

Closed
jroebu14 opened this issue Jun 2, 2021 · 2 comments · Fixed by #158
Closed

getEntriesByName is not supported in some versions of Opera #159

jroebu14 opened this issue Jun 2, 2021 · 2 comments · Fixed by #158

Comments

@jroebu14
Copy link
Contributor

jroebu14 commented Jun 2, 2021

Hi there,

We noticed that upgrading from v1.1.1 to v1.1.2 broke our application for our users on data saving mode in the Opera Mini browser.

We believe it was caused by this change 4dfde19

It seems that performance.getEntriesByName is not supported in some version of Opera.

So that we can upgrade the web-vitals package in our application, would you recommend we look for a polyfill for performance.getEntriesByName or should we contribute a fix?

Thanks

@philipwalton
Copy link
Member

The fix for this was released in v2.0.1, so you'll have to do a major version update to get it, but hopefully that's not a problem?

There was minimal breaking changes in the v2 update, mostly just the change to how CLS is calculated which you'll probably want to update to get anyway.

@jroebu14
Copy link
Contributor Author

jroebu14 commented Jun 3, 2021

Thanks for your help, @philipwalton. Yeh I don't think upgrading to v2 will be an issue 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants