This repository has been archived by the owner on Aug 31, 2021. It is now read-only.
Use uglify instead of minifify and fix up sourcemap generation #192
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R: @addyosmani @gauntface
Going with
uglify
as recommended in thegulp
docs seems to lead to a better-behaving sourcemap when used from Chrome's debugger.It also leads to a slightly smaller final bundle (15kb vs 17kb with
minifify
).This also fixes up the URL pointing to the sourcemap file, telling the debugger to look for the sourcemap in the same directory as the
sw-toolbox.js
library, rather than in a./build/
subdirectory.I decided to just inline the Apache 2.0 license header that gets prepending to the generated library, but if you think it's too messy that way, I can put it in a standalone file and then call
fs.readFileSync()
to bring it into the build.Fixes #169