This repository has been archived by the owner on Jan 23, 2021. It is now read-only.
Guard against empty caches due to a previously aborted install handler #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. Would love the promise chain to be broken up into smaller methods, like installAndUpdateChaches(), deleteOldCaches() just to make it a bit clearer, but that's personal preference. |
|
I'd like to refactor all the code in that file to use ES2015 features, and breaking things up into smaller pieces chained together with arrow functions would fit into that. See #82 (comment) |
This was referenced Apr 20, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R: @wibblymat @gauntface @addyosmani @ebidel
CC: @aeharding
This is something we've noticed from time to time in the I/O web app as well, so it's nice to get a fix in. I've got a couple of other changes that I'd like to roll up into a new minor release, so stay tuned for further PRs.
Fixes #103