feat(chromium): roll Chromium to r682225 #4844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is the headless team still using site-per-process=off? If so, I imagine other people will want it off for performance reasons. Maybe this fix should happen on the devtools side, so that devtools doesnt crash with this flag? |
| @@ -116,6 +117,13 @@ module.exports.addTests = function({testRunner, expect, puppeteer, defaultBrowse | |||
| await page.click('body'); | |||
| await browser.close(); | |||
| }); | |||
| it('should open devtools when "devtools: true" option is given', async({server}) => { | |||
There was a problem hiding this comment.
firefox won't like this
There was a problem hiding this comment.
Why? We run headful tests on CHROME only
I don't think there are any embedders that will use this in the long run - this mode is going away. |
This roll includes: - https://crrev.com/681997 - Turn on default SiteInstance by default. The SiteInstance by default was breaking "devtools: true" option, so there's a new feature we disable now by default. This keeps pressuring us towards OOPIF support since that's an inevitable future.
aslushnikov
force-pushed
the
fix-devtools
branch
from
218010f to
7dc788d
Compare
aslushnikov
changed the title
JoelEinbinder
approved these changes
Aug 14, 2019
This was referenced Dec 4, 2019
rfojtik
pushed a commit
to rfojtik/puppeteer
that referenced
this pull request
Dec 21, 2019
This roll includes: - https://crrev.com/681997 - Turn on default SiteInstance by default. The SiteInstance by default was breaking "devtools: true" option, so there's a new feature we disable now by default. This keeps pressuring us towards OOPIF support since that's an inevitable future.
This was referenced Feb 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This roll includes:
The SiteInstance by default was breaking "devtools: true" option, so
there's a new feature we disable now by default.
This keeps pressuring us towards OOPIF support since that's an
inevitable future.