Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(circleci): Add CircleCI to troubleshooting docs #4810

Merged
merged 1 commit into from
Aug 7, 2019
Merged

docs(circleci): Add CircleCI to troubleshooting docs #4810

merged 1 commit into from
Aug 7, 2019

Conversation

drwpow
Copy link

@drwpow drwpow commented Aug 6, 2019

This came from personal difficulties in running Puppeteer tests on CircleCI. I tried to keep the note as brief as possible, while being helpful for an entire CI platform.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@drwpow drwpow changed the title Add CircleCI to troubleshooting docs docs(circleci): Add CircleCI to troubleshooting docs Aug 6, 2019
@drwpow
Copy link
Author

drwpow commented Aug 6, 2019

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

Copy link
Contributor

@aslushnikov aslushnikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you!

@aslushnikov aslushnikov merged commit 374177b into puppeteer:master Aug 7, 2019
rfojtik pushed a commit to rfojtik/puppeteer that referenced this pull request Dec 21, 2019
This came from personal difficulties in running Puppeteer tests on CircleCI. I tried to keep the note as brief as possible, while being helpful for an entire CI platform.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants