fix(test): make sure selection is not empty before running copy command #4772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test/evaluation.spec.js
Outdated
| expect(result).toBe(true); | ||
| await page.evaluate(() => document.body.appendChild(document.createTextNode('test'))); | ||
| const selectResult = await page.evaluate(() => document.execCommand('selectAll')); | ||
| expect(selectResult).toBe(true); |
There was a problem hiding this comment.
Firefox is unhappy about this. Yay! Browsers!
Let's just do this with window.getSelection to not mess around more with execCommand than we have to, or just don't assert that the selectAll worked.
There was a problem hiding this comment.
Updated expectations to check only result of 'copy'.
…py command is sufficient
MedRedha
approved these changes
Jul 30, 2019
JoelEinbinder
approved these changes
Jul 30, 2019
test/evaluation.spec.js
Outdated
| @@ -226,6 +226,8 @@ module.exports.addTests = function({testRunner, expect}) { | |||
| expect(error.message).toContain('JSHandles can be evaluated only in the context they were created'); | |||
| }); | |||
| it('should simulate a user gesture', async({page, server}) => { | |||
| await page.evaluate(() => document.body.appendChild(document.createTextNode('test'))); | |||
There was a problem hiding this comment.
Nit: you can do these all in one evaluate, save some hops.
There was a problem hiding this comment.
Good point, done. Await and arrow functions make the code so much more readable that it's easy to forget that there are roundtrips over the protocol on each evaluate invocation :-)
This was referenced Dec 4, 2019
rfojtik
pushed a commit
to rfojtik/puppeteer
that referenced
this pull request
Dec 21, 2019
…nd (puppeteer#4772) If current selection is empty document.execCommand('copy') may return false in some browsers (e.g. WebKit based ones).
This was referenced Feb 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If current selection is empty document.execCommand('copy') may return false in some browsers (e.g. WebKit based ones).