From 8d93c122a7a02b219cee56292f2566cd294a17a6 Mon Sep 17 00:00:00 2001 From: Paul Irish Date: Wed, 14 Nov 2018 15:52:01 -0800 Subject: [PATCH 1/2] clients: skip h2 audit in LR --- lighthouse-core/config/lr-desktop-config.js | 1 + lighthouse-core/config/lr-mobile-config.js | 1 + 2 files changed, 2 insertions(+) diff --git a/lighthouse-core/config/lr-desktop-config.js b/lighthouse-core/config/lr-desktop-config.js index 76bdafb63445..babd21afb763 100644 --- a/lighthouse-core/config/lr-desktop-config.js +++ b/lighthouse-core/config/lr-desktop-config.js @@ -18,6 +18,7 @@ const config = { throughputKbps: 10 * 1024, cpuSlowdownMultiplier: 1, }, + skipAudits: ['uses-http2'], }, }; diff --git a/lighthouse-core/config/lr-mobile-config.js b/lighthouse-core/config/lr-mobile-config.js index 778acb403d51..b89cc7ab5ce8 100644 --- a/lighthouse-core/config/lr-mobile-config.js +++ b/lighthouse-core/config/lr-mobile-config.js @@ -10,6 +10,7 @@ const config = { extends: 'lighthouse:default', settings: { maxWaitForLoad: 35 * 1000, + skipAudits: ['uses-http2'], }, }; From cb8bd7a98b8d08342f582eaa926b493d0d4af8d3 Mon Sep 17 00:00:00 2001 From: Paul Irish Date: Wed, 14 Nov 2018 16:19:58 -0800 Subject: [PATCH 2/2] comment --- lighthouse-core/config/lr-desktop-config.js | 1 + lighthouse-core/config/lr-mobile-config.js | 1 + 2 files changed, 2 insertions(+) diff --git a/lighthouse-core/config/lr-desktop-config.js b/lighthouse-core/config/lr-desktop-config.js index babd21afb763..36ba73592b30 100644 --- a/lighthouse-core/config/lr-desktop-config.js +++ b/lighthouse-core/config/lr-desktop-config.js @@ -18,6 +18,7 @@ const config = { throughputKbps: 10 * 1024, cpuSlowdownMultiplier: 1, }, + // Skip the h2 audit so it doesn't lie to us. See #6539 skipAudits: ['uses-http2'], }, }; diff --git a/lighthouse-core/config/lr-mobile-config.js b/lighthouse-core/config/lr-mobile-config.js index b89cc7ab5ce8..264663542213 100644 --- a/lighthouse-core/config/lr-mobile-config.js +++ b/lighthouse-core/config/lr-mobile-config.js @@ -10,6 +10,7 @@ const config = { extends: 'lighthouse:default', settings: { maxWaitForLoad: 35 * 1000, + // Skip the h2 audit so it doesn't lie to us. See #6539 skipAudits: ['uses-http2'], }, };