From 3255bb34263ba1be5f9ab6b08d580601b7eef72f Mon Sep 17 00:00:00 2001 From: Connor Clark Date: Fri, 30 Sep 2022 11:40:11 -0700 Subject: [PATCH 1/2] core: save lhr to latest-run/ for -A, not just -GA --- core/runner.js | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/core/runner.js b/core/runner.js index 53adb821a482..94a567929245 100644 --- a/core/runner.js +++ b/core/runner.js @@ -121,8 +121,7 @@ class Runner { // LHR has now been localized. const lhr = /** @type {LH.Result} */ (i18nLhr); - // Save lhr to ./latest-run, but only if -GA is used. - if (settings.gatherMode && settings.auditMode) { + if (settings.auditMode) { const path = Runner._getDataSavePath(settings); assetSaver.saveLhr(lhr, path); } From 7d4c186988b1f40a69c415a5278cfb46f4894037 Mon Sep 17 00:00:00 2001 From: Connor Clark Date: Fri, 30 Sep 2022 11:43:42 -0700 Subject: [PATCH 2/2] update test --- core/test/runner-test.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/core/test/runner-test.js b/core/test/runner-test.js index 63fe224bcb08..5109c1a89c7f 100644 --- a/core/test/runner-test.js +++ b/core/test/runner-test.js @@ -144,7 +144,7 @@ describe('Runner', () => { expect(loadArtifactsSpy).toHaveBeenCalled(); expect(gatherRunnerRunSpy).not.toHaveBeenCalled(); expect(saveArtifactsSpy).not.toHaveBeenCalled(); - expect(saveLhrSpy).not.toHaveBeenCalled(); + expect(saveLhrSpy).toHaveBeenCalled(); expect(runAuditSpy).toHaveBeenCalled(); }); });