From c07502b97c3eeb2f3e39f4bae030edd10fbc68ec Mon Sep 17 00:00:00 2001
From: Connor Clark <cjamcl@google.com>
Date: Mon, 22 Nov 2021 13:46:08 -0800
Subject: [PATCH] misc(build): use rollup to create extension bundle

---
 build/build-extension.js | 39 ++++++++++++++++++++++-----------------
 1 file changed, 22 insertions(+), 17 deletions(-)

diff --git a/build/build-extension.js b/build/build-extension.js
index 40c9f12c0488..976cb958e827 100644
--- a/build/build-extension.js
+++ b/build/build-extension.js
@@ -9,8 +9,8 @@ const fs = require('fs');
 const mkdir = fs.promises.mkdir;
 const archiver = require('archiver');
 const cpy = require('cpy');
-const browserify = require('browserify');
-const path = require('path');
+const rollup = require('rollup');
+const rollupPlugins = require('./rollup-plugins.js');
 const {LH_ROOT} = require('../root.js');
 
 const argv = process.argv.slice(2);
@@ -26,25 +26,30 @@ const packagePath = `${distDir}/../extension-${browserBrand}-package`;
 const manifestVersion = require(`${sourceDir}/manifest.json`).version;
 
 /**
- * Browserify and minify entry point.
+ * Bundle and minify entry point.
  */
 async function buildEntryPoint() {
-  const inFile = `${sourceDir}/scripts/${sourceName}`;
-  const outFile = `${distDir}/scripts/${distName}`;
-  const bundleStream = browserify(inFile).bundle();
-
-  await mkdir(path.dirname(outFile), {recursive: true});
-  await new Promise((resolve, reject) => {
-    const writeStream = fs.createWriteStream(outFile);
-    writeStream.on('finish', resolve);
-    writeStream.on('error', reject);
-
-    bundleStream.pipe(writeStream);
+  const bundle = await rollup.rollup({
+    input: `${sourceDir}/scripts/${sourceName}`,
+    plugins: [
+      rollupPlugins.shim({
+        [`${LH_ROOT}/report/generator/flow-report-assets.js`]: 'export default {}',
+      }),
+      rollupPlugins.replace({
+        '___BROWSER_BRAND___': browserBrand,
+      }),
+      rollupPlugins.commonjs(),
+      rollupPlugins.nodeResolve(),
+      rollupPlugins.inlineFs({verbose: false}),
+      rollupPlugins.terser(),
+    ],
   });
 
-  let outCode = fs.readFileSync(outFile, 'utf-8');
-  outCode = outCode.replace('___BROWSER_BRAND___', browserBrand);
-  fs.writeFileSync(outFile, outCode);
+  await bundle.write({
+    file: `${distDir}/scripts/${distName}`,
+    format: 'iife',
+  });
+  await bundle.close();
 }
 
 /**