From d44de722c0b17fa9a0d376985242d65b92d71299 Mon Sep 17 00:00:00 2001 From: Connor Clark Date: Tue, 26 Oct 2021 18:33:43 -0700 Subject: [PATCH 1/4] core(config): use abbreviation for pwa category title --- lighthouse-core/config/default-config.js | 2 +- lighthouse-core/test/results/sample_v2.json | 2 +- shared/localization/locales/en-US.json | 2 +- shared/localization/locales/en-XL.json | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/lighthouse-core/config/default-config.js b/lighthouse-core/config/default-config.js index a0980fc3c41f..1930d751a42a 100644 --- a/lighthouse-core/config/default-config.js +++ b/lighthouse-core/config/default-config.js @@ -96,7 +96,7 @@ const UIStrings = { /** Description of the navigation section within the Search Engine Optimization (SEO) category. Within this section are audits with descriptive titles that highlight ways to make a website accessible to search engine crawlers. */ seoCrawlingGroupDescription: 'To appear in search results, crawlers need access to your app.', /** Title of the Progressive Web Application (PWA) category of audits. This is displayed at the top of a list of audits focused on topics related to whether or not a site is a progressive web app, e.g. responds offline, uses a service worker, is on https, etc. Also used as a label of a score gauge. */ - pwaCategoryTitle: 'Progressive Web App', + pwaCategoryTitle: 'PWA', /** Description of the Progressive Web Application (PWA) category. This is displayed at the top of a list of audits focused on topics related to whether or not a site is a progressive web app, e.g. responds offline, uses a service worker, is on https, etc. No character length limits. 'Learn More' becomes link text to additional documentation. */ pwaCategoryDescription: 'These checks validate the aspects of a Progressive Web App. ' + '[Learn more](https://developers.google.com/web/progressive-web-apps/checklist).', diff --git a/lighthouse-core/test/results/sample_v2.json b/lighthouse-core/test/results/sample_v2.json index 10e6591f1fcd..30762ad844f7 100644 --- a/lighthouse-core/test/results/sample_v2.json +++ b/lighthouse-core/test/results/sample_v2.json @@ -6655,7 +6655,7 @@ "score": 0.67 }, "pwa": { - "title": "Progressive Web App", + "title": "PWA", "description": "These checks validate the aspects of a Progressive Web App. [Learn more](https://developers.google.com/web/progressive-web-apps/checklist).", "manualDescription": "These checks are required by the baseline [PWA Checklist](https://developers.google.com/web/progressive-web-apps/checklist) but are not automatically checked by Lighthouse. They do not affect your score but it's important that you verify them manually.", "supportedModes": [ diff --git a/shared/localization/locales/en-US.json b/shared/localization/locales/en-US.json index 8d153809197f..b01c91f9b8d5 100644 --- a/shared/localization/locales/en-US.json +++ b/shared/localization/locales/en-US.json @@ -1788,7 +1788,7 @@ "message": "These checks are required by the baseline [PWA Checklist](https://developers.google.com/web/progressive-web-apps/checklist) but are not automatically checked by Lighthouse. They do not affect your score but it's important that you verify them manually." }, "lighthouse-core/config/default-config.js | pwaCategoryTitle": { - "message": "Progressive Web App" + "message": "PWA" }, "lighthouse-core/config/default-config.js | pwaInstallableGroupTitle": { "message": "Installable" diff --git a/shared/localization/locales/en-XL.json b/shared/localization/locales/en-XL.json index 0409d82edbbd..ce3480fbbade 100644 --- a/shared/localization/locales/en-XL.json +++ b/shared/localization/locales/en-XL.json @@ -1788,7 +1788,7 @@ "message": "T̂h́êśê ćĥéĉḱŝ ár̂é r̂éq̂úîŕêd́ b̂ý t̂h́ê b́âśêĺîńê [ṔŴÁ Ĉh́êćk̂ĺîśt̂](https://developers.google.com/web/progressive-web-apps/checklist) b́ût́ âŕê ńôt́ âút̂óm̂át̂íĉál̂ĺŷ ćĥéĉḱêd́ b̂ý L̂íĝh́t̂h́ôúŝé. T̂h́êý d̂ó n̂ót̂ áf̂f́êćt̂ ýôúr̂ śĉór̂é b̂út̂ ít̂'ś îḿp̂ór̂t́âńt̂ t́ĥát̂ ýôú v̂ér̂íf̂ý t̂h́êḿ m̂án̂úâĺl̂ý." }, "lighthouse-core/config/default-config.js | pwaCategoryTitle": { - "message": "P̂ŕôǵr̂éŝśîv́ê Ẃêb́ Âṕp̂" + "message": "P̂ẂÂ" }, "lighthouse-core/config/default-config.js | pwaInstallableGroupTitle": { "message": "Îńŝt́âĺl̂áb̂ĺê" From 11b879cf82a0cf2b00b92fe410f41aa7ab922da8 Mon Sep 17 00:00:00 2001 From: Connor Clark Date: Wed, 27 Oct 2021 13:26:56 -0700 Subject: [PATCH 2/4] test --- clients/extension/scripts/settings-controller.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/clients/extension/scripts/settings-controller.js b/clients/extension/scripts/settings-controller.js index 45529d6de7a1..500cb043662b 100644 --- a/clients/extension/scripts/settings-controller.js +++ b/clients/extension/scripts/settings-controller.js @@ -20,7 +20,7 @@ const DEFAULT_CATEGORIES = [{ title: 'SEO', }, { id: 'pwa', - title: 'Progressive Web App', + title: 'PWA', }]; /** @typedef {{selectedCategories: string[], device: string}} Settings */ From afb55c74bf4906b46f9a4659284cd729798c9756 Mon Sep 17 00:00:00 2001 From: Connor Clark Date: Thu, 28 Oct 2021 16:42:32 -0700 Subject: [PATCH 3/4] fixtest --- report/test/renderer/report-renderer-test.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/report/test/renderer/report-renderer-test.js b/report/test/renderer/report-renderer-test.js index 43f31bc957a4..1bdaff22d5f5 100644 --- a/report/test/renderer/report-renderer-test.js +++ b/report/test/renderer/report-renderer-test.js @@ -90,7 +90,7 @@ describe('ReportRenderer', () => { const output = renderer.renderReport(sampleResultsCopy, container); function isPWAGauge(el) { - return el.querySelector('.lh-gauge__label').textContent === 'Progressive Web App'; + return el.querySelector('.lh-gauge__label').textContent === 'PWA'; } function isPluginGauge(el) { return el.querySelector('.lh-gauge__label').textContent === 'Some Plugin'; From c20673c2cb2444820ebb01512b80abd76c41005d Mon Sep 17 00:00:00 2001 From: Connor Clark Date: Thu, 28 Oct 2021 16:43:24 -0700 Subject: [PATCH 4/4] test --- lighthouse-cli/test/cli/__snapshots__/index-test.js.snap | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lighthouse-cli/test/cli/__snapshots__/index-test.js.snap b/lighthouse-cli/test/cli/__snapshots__/index-test.js.snap index 54a1b5bb6b5e..f8f4b9982263 100644 --- a/lighthouse-cli/test/cli/__snapshots__/index-test.js.snap +++ b/lighthouse-cli/test/cli/__snapshots__/index-test.js.snap @@ -1246,7 +1246,7 @@ Object { "supportedModes": Array [ "navigation", ], - "title": "Progressive Web App", + "title": "PWA", }, "seo": Object { "auditRefs": Array [