misc: read locale files without using require
#12721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamraine
approved these changes
Jun 29, 2021
lighthouse-core/lib/i18n/locales.js
Outdated
| const fs = require('fs'); | ||
|
|
||
| /** @type {Record<string, LhlMessages>} */ | ||
| const l = { |
There was a problem hiding this comment.
This name is too short, maybe something like localeFiles
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #12689
preliminary change for converting this file (way down the line) to ES modules.
importing JSON modules won't be a thing for quite awhile, so we have to switch to fs. Must do all these reads w/o abstraction (no function for DRY) so that bundler can inline the contents for LR.