From 9bd275b876d945b9b0ffc6588a657327546ebf56 Mon Sep 17 00:00:00 2001 From: SphinxKnight Date: Fri, 21 Feb 2020 12:52:15 +0100 Subject: [PATCH 1/3] Fixing #10363 - Accessibility contrast for links I went with `--color-informative` which was already in use for some other links and it looks (locally) ok to me in order to fix #10363. --- lighthouse-core/report/html/report-styles.css | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lighthouse-core/report/html/report-styles.css b/lighthouse-core/report/html/report-styles.css index 6e0858f63732..2159142e84d8 100644 --- a/lighthouse-core/report/html/report-styles.css +++ b/lighthouse-core/report/html/report-styles.css @@ -341,7 +341,8 @@ .lh-audit-group a, .lh-category-header__description a, .lh-audit__description a, -.lh-footer a { +.lh-footer a +.lh-table-column-link a { color: var(--color-informative); } From 712592bdfbdcc5aad87987f760bb24fe0df0dc95 Mon Sep 17 00:00:00 2001 From: SphinxKnight Date: Sat, 22 Feb 2020 18:11:21 +0100 Subject: [PATCH 2/3] Typofixing missing comma --- lighthouse-core/report/html/report-styles.css | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lighthouse-core/report/html/report-styles.css b/lighthouse-core/report/html/report-styles.css index 2159142e84d8..9c37b2762760 100644 --- a/lighthouse-core/report/html/report-styles.css +++ b/lighthouse-core/report/html/report-styles.css @@ -341,7 +341,7 @@ .lh-audit-group a, .lh-category-header__description a, .lh-audit__description a, -.lh-footer a +.lh-footer a, .lh-table-column-link a { color: var(--color-informative); } From 98742a5fc3b4a91245cf52071e3607ff07178789 Mon Sep 17 00:00:00 2001 From: SphinxKnight Date: Tue, 25 Feb 2020 07:33:15 +0100 Subject: [PATCH 3/3] typofix per review (missing dash) Co-Authored-By: Connor Clark --- lighthouse-core/report/html/report-styles.css | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lighthouse-core/report/html/report-styles.css b/lighthouse-core/report/html/report-styles.css index 9c37b2762760..ae7e8ef5f8fc 100644 --- a/lighthouse-core/report/html/report-styles.css +++ b/lighthouse-core/report/html/report-styles.css @@ -342,7 +342,7 @@ .lh-category-header__description a, .lh-audit__description a, .lh-footer a, -.lh-table-column-link a { +.lh-table-column--link a { color: var(--color-informative); }