diff --git a/lighthouse-cli/test/fixtures/manifest.json b/lighthouse-cli/test/fixtures/manifest.json index 596f304cb5ca..0b4d4fc9c987 100644 --- a/lighthouse-cli/test/fixtures/manifest.json +++ b/lighthouse-cli/test/fixtures/manifest.json @@ -26,11 +26,6 @@ "src": "launcher-icon-3x.png", "sizes": "144x144", "type": "image/png" - }, - { - "src": "launcher-icon-4x.png", - "sizes": "192x192", - "type": "image/png" } ], "start_url": "http://localhost:10503/offline-ready.html", diff --git a/lighthouse-cli/test/smokehouse/test-definitions/pwa/pwa-expectations-details.js b/lighthouse-cli/test/smokehouse/test-definitions/pwa/pwa-expectations-details.js index df8ece78bb54..863a167f9174 100644 --- a/lighthouse-cli/test/smokehouse/test-definitions/pwa/pwa-expectations-details.js +++ b/lighthouse-cli/test/smokehouse/test-definitions/pwa/pwa-expectations-details.js @@ -8,7 +8,7 @@ module.exports = { isParseFailure: false, hasStartUrl: true, - hasIconsAtLeast192px: true, + hasIconsAtLeast144px: true, hasIconsAtLeast512px: true, hasPWADisplayValue: true, hasBackgroundColor: true, diff --git a/lighthouse-core/audits/installable-manifest.js b/lighthouse-core/audits/installable-manifest.js index 9f2109692d55..80432f62a223 100644 --- a/lighthouse-core/audits/installable-manifest.js +++ b/lighthouse-core/audits/installable-manifest.js @@ -33,7 +33,7 @@ const str_ = i18n.createMessageInstanceIdFn(__filename, UIStrings); * * manifest has a valid name * * manifest has a valid shortname * * manifest display property is standalone, minimal-ui, or fullscreen - * * manifest contains icon that's a png and size >= 192px + * * manifest contains icon that's a png and size >= 144px */ class InstallableManifest extends MultiCheckAudit { @@ -72,7 +72,7 @@ class InstallableManifest extends MultiCheckAudit { 'hasShortName', 'hasStartUrl', 'hasPWADisplayValue', - 'hasIconsAtLeast192px', + 'hasIconsAtLeast144px', ]; manifestValues.allChecks .filter(item => bannerCheckIds.includes(item.id)) diff --git a/lighthouse-core/computed/manifest-values.js b/lighthouse-core/computed/manifest-values.js index 0ea269b7ab1d..1c4035686095 100644 --- a/lighthouse-core/computed/manifest-values.js +++ b/lighthouse-core/computed/manifest-values.js @@ -28,10 +28,10 @@ class ManifestValues { validate: manifestValue => !!manifestValue.start_url.value, }, { - id: 'hasIconsAtLeast192px', - failureText: 'Manifest does not have a PNG icon of at least 192px', + id: 'hasIconsAtLeast144px', + failureText: 'Manifest does not have a PNG icon of at least 144px', validate: manifestValue => icons.doExist(manifestValue) && - icons.pngSizedAtLeast(192, manifestValue).length > 0, + icons.pngSizedAtLeast(144, manifestValue).length > 0, }, { id: 'hasIconsAtLeast512px', diff --git a/lighthouse-core/test/audits/installable-manifest-test.js b/lighthouse-core/test/audits/installable-manifest-test.js index 8b47752e67db..633a6ee06515 100644 --- a/lighthouse-core/test/audits/installable-manifest-test.js +++ b/lighthouse-core/test/audits/installable-manifest-test.js @@ -134,7 +134,7 @@ describe('PWA: webapp install banner audit', () => { const details = result.details.items[0]; assert.strictEqual(details.failures.length, 1, details.failures); assert.strictEqual(details.hasStartUrl, true); - assert.strictEqual(details.hasIconsAtLeast192px, false); + assert.strictEqual(details.hasIconsAtLeast144px, false); }); }); }); @@ -150,7 +150,7 @@ describe('PWA: webapp install banner audit', () => { const details = result.details.items[0]; assert.strictEqual(details.failures.length, 1, details.failures); assert.strictEqual(details.hasStartUrl, true); - assert.strictEqual(details.hasIconsAtLeast192px, false); + assert.strictEqual(details.hasIconsAtLeast144px, false); }); }); }); diff --git a/types/artifacts.d.ts b/types/artifacts.d.ts index 5dc356fd37c7..faa5e36ea924 100644 --- a/types/artifacts.d.ts +++ b/types/artifacts.d.ts @@ -435,7 +435,7 @@ declare global { } } - export type ManifestValueCheckID = 'hasStartUrl'|'hasIconsAtLeast192px'|'hasIconsAtLeast512px'|'hasPWADisplayValue'|'hasBackgroundColor'|'hasThemeColor'|'hasShortName'|'hasName'|'shortNameLength'; + export type ManifestValueCheckID = 'hasStartUrl'|'hasIconsAtLeast144px'|'hasIconsAtLeast512px'|'hasPWADisplayValue'|'hasBackgroundColor'|'hasThemeColor'|'hasShortName'|'hasName'|'shortNameLength'; export type ManifestValues = { isParseFailure: false;