-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Audit: Avoid file versioning for certain file types #9607
Comments
It's a good thing to avoid, but it seems super-hard to detect, though? If someone does decide to, e.g., add a hash into a service worker file, how many characters will that hash have? What will separate the hash from the file name? All of that is up to the developer and is hard to generalize. |
You're right, but there are some conventions that could be looked for. I think the convention usually looks something like: Plus developers are free to name the files anything they want, too. I think service workers are mostly named It may be that it isn't worth the effort of implementing such an audit, considering all the ways to version a file. I also don't have any data that suggests that this is even all that common of a mistake to support this audit request. |
FWIW, the |
This is a duplicate issue of #2570, closing. |
Developers should avoid versioning the URLs (as otherwise commonly used for cache-busting) of both service workers and web app manifest files as described in:
/cc @jeffposnick
The text was updated successfully, but these errors were encountered: