Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove audit list focus ring #9099

Closed
yuinchien opened this issue May 31, 2019 · 2 comments
Closed

Remove audit list focus ring #9099

yuinchien opened this issue May 31, 2019 · 2 comments

Comments

@yuinchien
Copy link
Collaborator

Provide the steps to reproduce

  1. Run LH on https://www.google.com/chrome/

What is the current behavior?

The default focus ring behavior is visible, according to the recent review, I recalled the decision was to use :focus-visible(only show the ring when focus via keyboard for accessibility). The rationale is that the focus ring creates bounding box that excludes the selected content (dropdown), and can be confusing to read, it also doesn't look pretty.

Screen Shot 2019-05-31 at 3 32 50 PM

Screen Shot 2019-05-31 at 3 32 47 PM

What is the expected behavior?

Screen Shot 2019-05-31 at 3 45 17 PM

Screen Shot 2019-05-31 at 3 45 14 PM

Environment Information

  • Affected Channels:
  • Lighthouse version: 5.1.0
  • Node.js version:
  • Operating System:

Related issues

@connorjclark
Copy link
Collaborator

:focus-visible is not ready for use yet - only in FF behind a vendor prefix, and Chrome behind an opt in flag.

Polyfill: https://github.com/WICG/focus-visible

@brendankenny
Copy link
Member

Focus ring is still sort of there, but has changed since this was filed (maybe most recently in #13249?). Closing as stale

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants