Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove disableDeviceEmulation flag before v5 #7044

Closed
patrickhulce opened this issue Jan 17, 2019 · 0 comments · Fixed by #8289
Closed

Remove disableDeviceEmulation flag before v5 #7044

patrickhulce opened this issue Jan 17, 2019 · 0 comments · Fixed by #8289
Labels
P2

Comments

@patrickhulce
Copy link
Collaborator

Summary
emulatedFormFactor was meant to replace disableDeviceEmulation, but I forgot to remove it before v4.

Note: Created from a TODO in code so it can be more visible and properly prioritized
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

core: remove disableDeviceEmulation flag GoogleChrome/lighthouse
2 participants
@paulirish @patrickhulce